Skip to content

Launch the sgl and miles routers through RayWorkerManager - #2051

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-67from
tom/refactor-miles/op13-60
Open

Launch the sgl and miles routers through RayWorkerManager#2051
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-67from
tom/refactor-miles/op13-60

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 61d00c7 to 2066269 Compare August 2, 2026 12:40
@fzyzcjy
fzyzcjy requested a review from yushengsu-thu as a code owner August 2, 2026 12:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch 4 times, most recently from 50341b4 to 0101c50 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 0135573 to c4c712b Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 0101c50 to fe10660 Compare August 4, 2026 07:26
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from c4c712b to ca8f68f Compare August 4, 2026 07:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from fe10660 to 7a3ef67 Compare August 4, 2026 07:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from ca8f68f to fea6d20 Compare August 4, 2026 07:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 7a3ef67 to 04a0a2f Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from fea6d20 to d0d8c55 Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 04a0a2f to eef744c Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from d0d8c55 to cd6e01f Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from eef744c to 4e46159 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 1cb441f to 6e3b6b1 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch 2 times, most recently from 3fe1f05 to 69207e8 Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 6e3b6b1 to 5ce1a4a Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 69207e8 to e0a35b6 Compare August 10, 2026 16:06
@@ -5,7 +5,9 @@
def compute_specs(args) -> list[BaseWorkerSpec]:
return [
*inference.specs_router(args),

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Keep debug_train_only free of rollout services

Codex review: launch_worker_manager() runs before the later InferenceController.init() guard, so compute_specs() still emits router workers in --debug-train-only mode. This does not affect training correctness, but it unnecessarily starts a router actor and binds ports despite the documented train-only contract; could we return no router specs when args.debug_train_only is set?

async def alloc_ports(self) -> None:
self.self_addrs = {}

node_ip = await self.actor_handle._get_node_ip.remote()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Preserve the MILES_HOST_IP router override

Codex review: this now derives the router host only from CommandActor._get_node_ip(), whereas the previous path used get_host_info() and honored MILES_HOST_IP. This is non-blocking when Ray’s node IP is already usable, but deployments that set the override for a container/pod address will bind and publish the Ray-detected IP instead. The behavior remains present through #2176 and #2649; could the router spec carry an explicit bind/advertised-host override?

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex stack review: #2054 completes the router/session placement transition, while #2053 and #2057 close the source-test gaps; all land before safe-merge checkpoint #2176 and remain intact through checked tip #2649. The two inline comments are non-blocking follow-ups.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from c3f297b to 9bea8bb Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 1769125 to 9109b90 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 9bea8bb to 9e4f595 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 9109b90 to 7104b97 Compare August 31, 2026 23:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 9e4f595 to e89d381 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 7104b97 to b9cf9af Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from e89d381 to e6769b0 Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch 2 times, most recently from 729ca7f to 7f47dbe Compare September 1, 2026 14:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch 2 times, most recently from 9980dea to fddd65e Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 7f47dbe to 814eabd Compare September 3, 2026 06:02
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from fddd65e to c7a042d Compare September 3, 2026 06:20
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 814eabd to 3692a27 Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from c7a042d to 8de5de6 Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-60 branch from 3692a27 to 83c7bcd Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-67 branch from 8de5de6 to f462e48 Compare September 3, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants