Skip to content

Launch session servers through RayWorkerManager - #2054

Merged
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-62
Sep 4, 2026
Merged

Launch session servers through RayWorkerManager#2054
fzyzcjy merged 1 commit into
mainfrom
tom/refactor-miles/op13-62

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from c4a8149 to 8ad4e2a Compare August 2, 2026 12:40
@fzyzcjy
fzyzcjy requested a review from yushengsu-thu as a code owner August 2, 2026 12:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 10aff41 to dbe7f6b Compare August 2, 2026 12:40
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 8ad4e2a to d2f81bb Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from dbe7f6b to 892af8c Compare August 3, 2026 23:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from d2f81bb to fe7b37c Compare August 4, 2026 00:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 2 times, most recently from cd92abc to 57d8525 Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy requested a review from Rockdu as a code owner August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from fe7b37c to 191042e Compare August 4, 2026 06:55
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 57d8525 to 420b243 Compare August 4, 2026 07:26
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 191042e to 3c35cc7 Compare August 4, 2026 07:27
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 420b243 to 1238e42 Compare August 4, 2026 07:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 3c35cc7 to 472f614 Compare August 4, 2026 07:34
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 1238e42 to 720277a Compare August 6, 2026 03:48
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch 2 times, most recently from cdc5003 to fc5ba79 Compare August 6, 2026 07:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 2 times, most recently from 639cd30 to 7d48001 Compare August 9, 2026 23:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from fc5ba79 to 7f7520a Compare August 9, 2026 23:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 2 times, most recently from a92b5e9 to 3a80332 Compare August 10, 2026 06:04
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 55f41df to e990cb6 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 2 times, most recently from 6e89ac3 to fc6ed5d Compare August 13, 2026 03:25
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from a95ea8a to d83bee8 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from fc6ed5d to 65a7705 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from d83bee8 to b53b36b Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 2 times, most recently from 9be5a48 to 4924b3a Compare August 14, 2026 04:46

@guapisolo guapisolo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in stack context.

[P1] #2054's session-server address contract cannot represent multi-host placement and can abort startup; #2305 fixes it before safe merge checkpoint #2176, and the repair remains intact through the checked #2649 tip.

@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 1dd28dd to b3489e6 Compare August 29, 2026 12:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 3 times, most recently from c81510e to f9d3da2 Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 96ec832 to 540cafa Compare September 1, 2026 10:03
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from f9d3da2 to 9d4c57d Compare September 1, 2026 10:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch 2 times, most recently from 446c9af to 92cf74c Compare September 1, 2026 14:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch 3 times, most recently from f2a9733 to d6fe73a Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 74489a6 to cfd373f Compare September 3, 2026 06:21
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from d6fe73a to 8bf6a8e Compare September 3, 2026 06:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 0d91a3e to 2b53c25 Compare September 3, 2026 07:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 8bf6a8e to 2901fd4 Compare September 3, 2026 07:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-68 branch from 2b53c25 to f6333de Compare September 3, 2026 10:52
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-62 branch from 2901fd4 to 7e289a7 Compare September 3, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants