Launch the sgl and miles routers as command-line subprocesses - #1976
Open
fzyzcjy wants to merge 1 commit into
Open
Launch the sgl and miles routers as command-line subprocesses#1976fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
fzyzcjy
requested review from
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper,
maocheng23,
yueming-yuan and
yushengsu-thu
as code owners
July 30, 2026 14:50
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 3, 2026 23:44
3c25cae to
d11009f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 4, 2026 00:39
5abc3cf to
fa15e0c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 4, 2026 00:39
d11009f to
df98db5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 4, 2026 06:55
fa15e0c to
c5747e3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 4, 2026 06:55
df98db5 to
cedb710
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 4, 2026 07:27
c5747e3 to
0fef6c5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 4, 2026 07:28
cedb710 to
a086f1e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 4, 2026 07:34
0fef6c5 to
0eb3ff3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 6, 2026 03:48
bc041ea to
56bd3e9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
2 times, most recently
from
August 6, 2026 07:03
1770069 to
98b2b9e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 9, 2026 23:33
48c3201 to
30e5076
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 10, 2026 06:04
024fee0 to
302b81b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 10, 2026 06:05
30e5076 to
097764f
Compare
yueming-yuan
approved these changes
Aug 10, 2026
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 10, 2026 16:07
302b81b to
7d7af58
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 10, 2026 16:07
097764f to
161fa0e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 10, 2026 16:34
7d7af58 to
bd64922
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 12, 2026 02:48
12c94dc to
ff6d55b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 12, 2026 14:31
25341b5 to
ace9852
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 12, 2026 14:36
37755e2 to
5902f16
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 12, 2026 14:36
ace9852 to
344b3a4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 12, 2026 23:56
5902f16 to
d882aa3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
2 times, most recently
from
August 13, 2026 01:13
d734533 to
ce30961
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 13, 2026 01:13
d882aa3 to
b9f0287
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 13, 2026 03:25
ce30961 to
7aa9b9b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 13, 2026 06:00
0526ff7 to
8015968
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 13, 2026 06:39
044fb9f to
566b99e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
2 times, most recently
from
August 14, 2026 04:45
4877c36 to
f8ddffc
Compare
guapisolo
reviewed
Aug 26, 2026
| ) | ||
| process.daemon = True | ||
| process.start() | ||
| process = process_utils.launch_bound_subprocess(launch_argv, envs={}) |
Collaborator
There was a problem hiding this comment.
[P1] On Linux, launch_bound_subprocess() passes a Python preexec_fn to Popen. This call runs after Ray/tracking have started threads, and CPython warns that preexec_fn can deadlock before exec; in that case Popen never returns, so the 30s readiness timeout never starts. Could we preserve PR_SET_PDEATHSIG via an exec-first trampoline (or equivalent) without running Python preexec_fn in the multithreaded parent? I traced this through #2176 and #2649; #1988 only moves the same helper call into a Ray CommandActor, so it remains unresolved.
start_router now renders a command line instead of spawning a multiprocessing child: the sgl router runs its upstream CLI via a RouterArgs-to-argv renderer that diffs against the CLI defaults and roundtrip-asserts on every render, and the miles router gains a __main__ entry fed by the config-json boundary. Both run under launch_bound_subprocess so the parent-death semantics of the daemon children are preserved, wait_for_server_ready learns to watch a Popen, and the router spec's launch_command is rendered by the same functions so the spec cannot drift from the launch path.
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-8
branch
from
August 29, 2026 12:38
f8ddffc to
896d02f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op13-7
branch
from
August 29, 2026 12:38
85040ca to
588422c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837