Restructure start_engines into per-cell blocks and assume engines in one cell have same lifecycle - #1877
Open
fzyzcjy wants to merge 1 commit into
Open
Restructure start_engines into per-cell blocks and assume engines in one cell have same lifecycle#1877fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
July 28, 2026 13:31
028d28b to
b5b34d0
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
2 times, most recently
from
August 3, 2026 23:44
6dcfbd7 to
69a82f8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 3, 2026 23:44
b5b34d0 to
588c610
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 4, 2026 00:39
69a82f8 to
da8a37d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 4, 2026 00:39
588c610 to
6daddff
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 4, 2026 06:57
da8a37d to
7cecf83
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 4, 2026 06:57
6daddff to
34d1cd5
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 6, 2026 07:03
7cecf83 to
eb791e9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 6, 2026 07:03
34d1cd5 to
0e997f4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 10, 2026 06:07
eb791e9 to
89eef17
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 10, 2026 06:07
0e997f4 to
1c046e4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 10, 2026 16:07
89eef17 to
f2c73a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
2 times, most recently
from
August 10, 2026 16:34
b009b5b to
ff8f3fb
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 10, 2026 16:34
f2c73a2 to
d15cdac
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 12, 2026 02:48
ff8f3fb to
c87a468
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 12, 2026 14:31
7f6db1e to
eb54bd8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 12, 2026 14:31
c87a468 to
034cd28
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 12, 2026 23:56
eb54bd8 to
c7039dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
4 times, most recently
from
August 13, 2026 06:01
f893574 to
d5fbe26
Compare
…one cell have same lifecycle Each cell now creates its actors, allocates its ports and sets its addressing as one contiguous block, keeping the flat-order allocation sequence identical; the init handles are still awaited together.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-12
branch
from
August 14, 2026 04:45
5acf6a2 to
ceb9c73
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-13
branch
from
August 14, 2026 04:46
d5fbe26 to
84220d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837