Probe every node of a cell concurrently to avoid serialized initialization - #1889
Open
fzyzcjy wants to merge 1 commit into
Open
Probe every node of a cell concurrently to avoid serialized initialization#1889fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 3, 2026 23:45
29763ac to
c9e3b7e
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
2 times, most recently
from
August 4, 2026 00:39
0655fc9 to
4df5c86
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
2 times, most recently
from
August 4, 2026 06:58
2817005 to
f374cec
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:58
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
2 times, most recently
from
August 6, 2026 07:03
3c9dd90 to
bdb22dc
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 6, 2026 07:03
f374cec to
9ccc542
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
from
August 9, 2026 23:33
bdb22dc to
f681b07
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
2 times, most recently
from
August 10, 2026 06:08
eb4c695 to
55de553
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
2 times, most recently
from
August 10, 2026 16:07
5a80c5c to
dd6c33d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 10, 2026 16:34
3480f66 to
45a6586
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
2 times, most recently
from
August 12, 2026 02:48
0272cbd to
e635c70
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 12, 2026 14:31
2ec48ab to
60d4ae2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
from
August 12, 2026 14:31
e635c70 to
318e633
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 12, 2026 23:56
60d4ae2 to
6bb2627
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
from
August 12, 2026 23:56
318e633 to
1aa7b0d
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
3 times, most recently
from
August 13, 2026 06:01
a994476 to
dcd7fb8
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-4
branch
from
August 14, 2026 04:46
9f666a9 to
8d505ca
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op7-7
branch
from
August 14, 2026 04:46
dcd7fb8 to
26a1f92
Compare
Collaborator
|
This incremental change itself reviewed cleanly, but I cannot approve it for the #2176 safe-merge checkpoint: the lifecycle race introduced in #1878 is still reachable through the direct RayWorkerManager.start_cells()/stop_cells() path at #2176. #2108 only protects the older controller path; the complete shared membership lock does not land until #2622. Please move that fix before #2176, or move the checkpoint past the complete fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837