Refactor to remove allocate_rollout_engine_addr_and_ports_normal - #1875
Open
fzyzcjy wants to merge 1 commit into
Open
Refactor to remove allocate_rollout_engine_addr_and_ports_normal#1875fzyzcjy wants to merge 1 commit into
fzyzcjy wants to merge 1 commit into
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 3, 2026 23:44
8049dac to
dc38c1c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 3, 2026 23:44
00d7f71 to
c670bc3
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 4, 2026 00:39
dc38c1c to
cdc8c1f
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 4, 2026 00:39
c670bc3 to
e5d3ce9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 4, 2026 06:57
cdc8c1f to
23c20fa
Compare
fzyzcjy
requested review from
Rockdu,
Shi-Dong,
Zhichenzzz,
guapisolo,
jybsuper and
yushengsu-thu
as code owners
August 4, 2026 06:57
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 4, 2026 06:57
e5d3ce9 to
f9e2f2c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 10, 2026 06:07
f465bcd to
e34f5f9
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
2 times, most recently
from
August 10, 2026 16:07
5a8aa57 to
ae9ef9b
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 10, 2026 16:07
e34f5f9 to
27f7dce
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 10, 2026 16:34
ae9ef9b to
8c1cc7a
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 12, 2026 02:48
1fb4d92 to
d31c66c
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 12, 2026 14:31
74bb84d to
312d013
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
2 times, most recently
from
August 12, 2026 23:56
310dda2 to
979f051
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 13, 2026 01:13
7c11f3d to
5249f62
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 13, 2026 01:13
979f051 to
12bc976
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 13, 2026 03:25
12bc976 to
80f1dd4
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-11
branch
from
August 13, 2026 06:01
31561c5 to
f8131a2
Compare
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 13, 2026 06:01
80f1dd4 to
fd62164
Compare
allocate_rollout_engine_addr_and_ports_normal is inlined into ServerGroup.start_engines: the cell list is derived from new_engine_indices, ports are probed via the underlying actor handle, and the padding that filled addressing entries up to the end of each node is dropped, since only the newly launched engines are ever initialized from it. addr_and_ports stays keyed by global rank, as before. The addressing tests drive ServerGroup.start_engines now that the allocation function they called is gone. disaggregation_bootstrap_port stays prefill-only, so a regular or decode engine neither reserves a port for it nor reports a bootstrap_port in its AddrInfo.
fzyzcjy
force-pushed
the
tom/refactor-miles/op5-10
branch
from
August 14, 2026 04:45
fd62164 to
f666bf2
Compare
guapisolo
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1837