Skip to content

Serve rollout cells over the api server - #2115

Open
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-126from
tom/refactor-miles/op13-114
Open

Serve rollout cells over the api server#2115
fzyzcjy wants to merge 1 commit into
tom/refactor-miles/op13-126from
tom/refactor-miles/op13-114

Conversation

@fzyzcjy

@fzyzcjy fzyzcjy commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Part of #1837

@gemini-code-assist

gemini-code-assist Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@fzyzcjy fzyzcjy mentioned this pull request Aug 3, 2026
Open
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 18acc94 to adc70ae Compare August 3, 2026 23:43
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 2 times, most recently from 8a29e71 to 62d0237 Compare August 4, 2026 00:38
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch 2 times, most recently from 21b036b to 1e1fe6a Compare August 4, 2026 02:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 2 times, most recently from 6a1dd1c to 35d62d1 Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 1e1fe6a to 06de68c Compare August 4, 2026 02:36
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 35d62d1 to 9fc44a3 Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 06de68c to 1cafbad Compare August 4, 2026 06:53
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 9fc44a3 to b529011 Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 1cafbad to e07bf9f Compare August 4, 2026 07:24
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from b529011 to 63dc4c6 Compare August 4, 2026 07:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from e07bf9f to 8573f5a Compare August 4, 2026 07:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 63dc4c6 to bb5de6a Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 8573f5a to 3524845 Compare August 6, 2026 03:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 2 times, most recently from b89a2a1 to f6a4f9c Compare August 9, 2026 23:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch 2 times, most recently from 8e61cd0 to cfc71d5 Compare August 10, 2026 00:44
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 2 times, most recently from 237b022 to 7994b51 Compare August 10, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch 2 times, most recently from 07b0fd3 to 6e7b976 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 7994b51 to 6541f30 Compare August 10, 2026 16:06
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 6e7b976 to 9fca580 Compare August 10, 2026 16:33
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 3 times, most recently from 67b4e96 to 97bab45 Compare August 12, 2026 09:32
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 13128d0 to 57c0127 Compare August 12, 2026 14:31
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 3 times, most recently from e4c5cda to ae9a60a Compare August 12, 2026 23:56
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 3f56e53 to ad68abf Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from ae9a60a to 02c7fac Compare August 13, 2026 01:13
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from ad68abf to 7ae68f7 Compare August 13, 2026 03:11
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch 3 times, most recently from 4e52d80 to 7606ae2 Compare August 13, 2026 06:00
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch 2 times, most recently from 744ae38 to a2ab5d6 Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 7606ae2 to 4d071be Compare August 13, 2026 06:39
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from a2ab5d6 to 9011f01 Compare August 14, 2026 04:46
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 4d071be to 68a7c07 Compare August 14, 2026 04:46
This was referenced Aug 25, 2026
Open
Open
@fzyzcjy
Serve rollout cells over the api server
dab8e9f 
The rollout handle called controller methods that do not exist. It now reads the
two sources that own its facts: the worker manager says which cells have a live
process and is what suspend and resume drive, and the inference controller
supplies the already-rendered status of the cells it tracks.

The handle stays a pure adapter: it merges in suspension, which only the manager
knows, and otherwise passes the controller's status straight through. A cell the
manager has launched but reconcile has not handed over yet reports Pending with
no Healthy condition, so the ft controller does not heal an engine that is
merely waiting to be observed.
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-114 branch from 68a7c07 to dab8e9f Compare August 28, 2026 11:41
@fzyzcjy
fzyzcjy force-pushed the tom/refactor-miles/op13-126 branch from 9011f01 to 79b9ad9 Compare August 28, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yueming-yuan yueming-yuan Awaiting requested review from yueming-yuan yueming-yuan is a code owner
@guapisolo guapisolo Awaiting requested review from guapisolo guapisolo is a code owner
@maocheng23 maocheng23 Awaiting requested review from maocheng23 maocheng23 is a code owner
@jybsuper jybsuper Awaiting requested review from jybsuper jybsuper is a code owner
@Zhichenzzz Zhichenzzz Awaiting requested review from Zhichenzzz Zhichenzzz is a code owner
@Shi-Dong Shi-Dong Awaiting requested review from Shi-Dong Shi-Dong is a code owner
@yushengsu-thu yushengsu-thu Awaiting requested review from yushengsu-thu
@Rockdu Rockdu Awaiting requested review from Rockdu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fzyzcjy