move pin and use text file to store active pt pin #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
I think last time we needed to move both the pin here and the pin that executorch uses for PT at the same time? |
* add ET runner to benchmark * remove spurios end * add mps runner and groupsize kludge * adjust groupsize * fortify runners * handle device for export_et
* ensure test is red when error * macos version * upgrade xcode * fix workflow error * suppress error in readme using updown skip
* fix cmake version, p[adding for a8w4dq, lint... * fix cmake version, p[adding for a8w4dq, lint... * updates * fix
* improve updown parser, and use in README.md execution * cut/paste errors * typo: true -> false * we scan each partial line, so need to suppress at partial line level :( * make it twice as nice * improved updown parsing * special handling for lines w/o option * typo
Fix typo
* refactoring the readme * continued refining * more cleanup * more cleanup * more cleanup * more cleanup * more cleanup * more refining * Update README.md Update README.md * move the discaimer down * remove torchtune from main readme Fix pathing issues for runner commands * don't use pybindings for et setup --------- Co-authored-by: Michael Gschwind <[email protected]>
* better engineering * cleanup
`torch.zero`->`torch.zeros`, as former does not exist. Also, capture only `RuntimeErrors` to avoid making such typos in the future
As titled. This is to make sure we are locating the libtorch.so/dylib with the correct version number.
* Update run-readme-pr.yml * Update run-readme-pr-macos.yml Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Replace tokenizer path as well Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
* help outputs the default model dir
* Handle compile for export and generate * typo * typo * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use text file to store active pt pin
move pin to 20240503 nightly