Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help outputs the default model dir #713

Merged
merged 2 commits into from
May 7, 2024
Merged

help outputs the default model dir #713

merged 2 commits into from
May 7, 2024

Conversation

byjlw
Copy link
Contributor

@byjlw byjlw commented May 7, 2024

user can now see where their models live if they're using the default

@byjlw byjlw requested review from orionr, GregoryComer and mikekgfb May 7, 2024 19:02
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 7, 2024
cli.py Outdated
@@ -287,15 +287,15 @@ def _add_arguments_common(parser):
)
parser.add_argument(
"--hf-token",
type=str,
type=tstr,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a type I'm not aware of or a typo @byjlw ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awkward. yeah that wasn't intentional.

Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me other than what I think is a typo. Do we want to do this with any of the other defaults?

Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@orionr orionr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orionr orionr merged commit bc62255 into main May 7, 2024
34 checks passed
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
malfet pushed a commit that referenced this pull request Jul 17, 2024
* help outputs the default model dir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants