-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
help outputs the default model dir #713
Conversation
cli.py
Outdated
@@ -287,15 +287,15 @@ def _add_arguments_common(parser): | |||
) | |||
parser.add_argument( | |||
"--hf-token", | |||
type=str, | |||
type=tstr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a type I'm not aware of or a typo @byjlw ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awkward. yeah that wasn't intentional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me other than what I think is a typo. Do we want to do this with any of the other defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* help outputs the default model dir
* help outputs the default model dir
* help outputs the default model dir
* help outputs the default model dir
* help outputs the default model dir
* help outputs the default model dir
user can now see where their models live if they're using the default