make num samples work for directed prompt-based sequence generation #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@helloguo you can use the performance reporting and prompt-based sequence generation with support for --num-samples for benchmarking your ARM desktop performance improvements in pytorch/pytorch#125611 |
larryliu0820
reviewed
May 7, 2024
| @@ -743,28 +746,33 @@ def callback(x): | |||
| tokens_generated = y.size(0) - prompt_length | |||
| tokens_sec = tokens_generated / t | |||
| aggregate_metrics["tokens_per_sec"].append(tokens_sec) | |||
| logging.debug( | |||
| print( | |||
There was a problem hiding this comment.
Is this change intentional? Like we want to always print this
There was a problem hiding this comment.
Yes, performance info is not logging. This is the whole reason we run this, we can't just shove it into a log. Mind you, we do dump the entire IR on people when we export from ET.
There was a problem hiding this comment.
It feels like this is a regression from a previous decision we've made, and logging.info should have been sufficient there.. (or setup logger in main routine
larryliu0820
approved these changes
May 7, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make num samples work for directed prompt-based sequence generation