Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xnnpack to default build #712

Merged
merged 1 commit into from
May 8, 2024
Merged

Add xnnpack to default build #712

merged 1 commit into from
May 8, 2024

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented May 7, 2024 •
edited
Loading

  • Add xnnpack to default build
  • Include build_native in pull.yml

#702

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label May 7, 2024
@lucylq lucylq force-pushed the lfq.scripts-et-native branch 3 times, most recently from e6cff4e to 33c9d1d Compare May 7, 2024 22:19
lucylq
lucylq commented May 7, 2024
View reviewed changes
scripts/install_utils.sh
@@ -63,7 +63,8 @@ COMMON_CMAKE_ARGS="\
-DEXECUTORCH_BUILD_KERNELS_OPTIMIZED=ON \
-DEXECUTORCH_BUILD_EXTENSION_DATA_LOADER=ON \
-DEXECUTORCH_BUILD_EXTENSION_MODULE=ON \
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON"
-DEXECUTORCH_BUILD_KERNELS_QUANTIZED=ON \
-DEXECUTORCH_BUILD_XNNPACK=ON"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include xnnpack by default

@lucylq lucylq requested review from byjlw and larryliu0820 May 7, 2024 22:21
@lucylq lucylq marked this pull request as ready for review May 7, 2024 22:21
@lucylq lucylq changed the title update et.cmake for native Add xnnpack to default build May 7, 2024
@lucylq lucylq force-pushed the lfq.scripts-et-native branch from 33c9d1d to 02528d4 Compare May 7, 2024 22:23
mikekgfb
mikekgfb approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@mikekgfb mikekgfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mikekgfb mikekgfb merged commit 17fc0bb into main May 8, 2024
34 checks passed
@mikekgfb mikekgfb deleted the lfq.scripts-et-native branch May 8, 2024 06:59
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
4a318a4
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
52689ea
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
99b567e
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
c9f2510
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
85a7cbc
malfet pushed a commit that referenced this pull request Jul 17, 2024
@lucylq @malfet
update et.cmake for native (#712)
0bbf0be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikekgfb mikekgfb mikekgfb approved these changes

@byjlw byjlw Awaiting requested review from byjlw

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucylq @mikekgfb @facebook-github-bot