Skip to content

Post pylint 3.0.3#9299

Merged
jacobtylerwalls merged 18 commits intomainfrom
post-3.0.3-take-two
Dec 11, 2023
Merged

Post pylint 3.0.3#9299
jacobtylerwalls merged 18 commits intomainfrom
post-3.0.3-take-two

Conversation

@jacobtylerwalls
Copy link
Copy Markdown
Member

@Pierre-Sassoulas let me know how this looks, I'm eager to learn the blessed way of doing this. Do you generally fixup the second commit removing the fragments into the merge commit? When I attempted doing that, I was presented with a long list of rebase merge conflicts for all the caboose commits before the patch release commit.

Or, will we squash merge this anyway?

github-actions Bot and others added 18 commits October 11, 2023 22:41
Closes #8524

(cherry picked from commit ce8d1a9)

Co-authored-by: theirix <theirix@gmail.com>
… (#9155)

* [inconsistent-quotes] Emit for f-strings for 3.12 only

* Add docs for inconsistent-quotes with f-strings

Despite ``sys.version`` check, pylint raises the warning
with Python 3.11

(cherry picked from commit 1c0bc70)

Co-authored-by: theirix <theirix@gmail.com>
) (#9154)

* Fix `used-before-assignment` FP for generic type syntax (Py 3.12)

* Bump astroid to 3.0.1

(cherry picked from commit cb29fbd)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
(cherry picked from commit df0800e)

Co-authored-by: theirix <theirix@gmail.com>
(cherry picked from commit 67f20bd)

Co-authored-by: theirix <theirix@gmail.com>
…) (#9199)

(cherry picked from commit c648f16)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
This simplifies the check for the call having kwargs but not the lambda.

(cherry picked from commit 2289c71)

Co-authored-by: Clément Schreiner <clement@mux.me>
(cherry picked from commit 5546fe8)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
(cherry picked from commit 6f83d5a)

Co-authored-by: Sayyed Faisal Ali <80758388+C0DE-SLAYER@users.noreply.github.com>
New sphinx now check that a block of code is valid.
…h a __init__.py file (#9286)

* [bugfix] Find files with ./ as input with a __init__.py file (#9211)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Daniël van Noord <13665637+DanielNoord@users.noreply.github.com>
(cherry picked from commit abdb874)
…#9269) (#9287)

(cherry picked from commit 796eae3)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
…on types (#9289) (#9291)

(cherry picked from commit 8d4c6c1)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
Refs #9270

(cherry picked from commit 47410ad)

Co-authored-by: Jacob Walls <jacobtylerwalls@gmail.com>
@jacobtylerwalls jacobtylerwalls added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry labels Dec 11, 2023
@jacobtylerwalls
Copy link
Copy Markdown
Member Author

Or should I push to maintenance/3.0.x instead of pushing to a fresh branch?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 11, 2023

Codecov Report

Merging #9299 (4860b82) into main (3d5bd53) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9299   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         173      173           
  Lines       18767    18767           
=======================================
  Hits        17981    17981           
  Misses        786      786           

@jacobtylerwalls
Copy link
Copy Markdown
Member Author

I guess we can't squash merge because then we'd lose the commit we need for pre-commit autoupdate, which was the whole point of doing it this way instead of #9297.

Anyway, long story short, I'd very much appreciate as a precise a recipe to follow as we can muster! 💜

@Pierre-Sassoulas
Copy link
Copy Markdown
Member

Pierre-Sassoulas commented Dec 11, 2023

😄 So the way I'm doing it is as follow:

git fetch -ap
git switch maintenance/3.0.x
git pull
git branch merge-maintenance-into-main
git merge origin/main
# fix obvious conflicts (at least the 3 places where there's conflicting versions)
git merge --continue
# while not(the only changes are the changelog, possibly changes in Contributors.txt)
    # Check the while condition with
    git diff origin/main
    # Fix things then fixup the merge commit
    git commit -a --amend
git push pierre
# Open a merge request from pierre/merge-maintenance-into-main to origin/main
# Select "Create a merge commit" enable auto-merge (so no one squash it after approving review by mistake)
# Wait for review

@Pierre-Sassoulas
Copy link
Copy Markdown
Member

Having to remove manually the fragments so they don't end up on main would be more work. (Which is why I was not very argumentative with Daniel even if I think that we should not duplicate the changelog between patch and minor). Should probably be done with tbump or a script, or we won't release as often.

Copy link
Copy Markdown
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; you did something similar, and we simply need to use merge not squash or rebase, right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news 🔇 This change does not require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants