fix unnecessary-comprehension provides incorrect suggestion

[faisalalisayyed]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Closes #9109

[jacobtylerwalls]

Thanks for the patch!

Based on the test results, you'll notice you'll need to adjust the logic of #4500 to make it a little dumber (and therefore more like the original intent of #2999).

[faisalalisayyed]

@jacobtylerwalls i am a beginner and having a hard time solving can you help me what i have to do to solve the issue. it would be a great help! thanks

[Pierre-Sassoulas]

I'm on mobile si I can't link the specific code but the message is raised in the add_message function, the message is dynamic and the argument given to add_message used in %s later is what need to be modified.

[codecov]

Codecov Report

Merging #9172 (1bc8f5e) into main (df0800e) will increase coverage by 0.02%.
Report is 22 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9172      +/-   ##
==========================================
+ Coverage   95.76%   95.79%   +0.02%     
==========================================
  Files         173      173              
  Lines       18692    18722      +30     
==========================================
+ Hits        17901    17935      +34     
+ Misses        791      787       -4     

Files	Coverage Δ
pylint/checkers/refactoring/refactoring_checker.py	98.24% <100.00%> (+<0.01%)	⬆️

... and 11 files with indirect coverage changes

[Pierre-Sassoulas]

Thank you for your contribution, it looks promising, do you mind adding the functional tests from #8577

a = [[1, 2], [3, 4]]
b = [(x, y) for x, y in a]  # flagged as unnecessary-comprehension

And #9109:

#pylint: disable=missing-module-docstring
a = [1, 2, 3]
b = [x for x in a]
b[0] = 0
print(a) # [1, 2, 3]

in tests/functional/u/unnecessary/unnecessary_comprehension.py, please ?

[Pierre-Sassoulas]

Also a bug / or false positive changelog fragment would be nice for this one.

[faisalalisayyed]

Thank you for your contribution, it looks promising, do you mind adding the functional tests from #8577

a = [[1, 2], [3, 4]]
b = [(x, y) for x, y in a]  # flagged as unnecessary-comprehension

And #9109:

#pylint: disable=missing-module-docstring
a = [1, 2, 3]
b = [x for x in a]
b[0] = 0
print(a) # [1, 2, 3]

in tests/functional/u/unnecessary/unnecessary_comprehension.py, please ?

in the unnecessary_comprehension.py on line 5 it can be use for 9109 and
for 8577 ' [(x, y) for x, y in iterable] # [unnecessary-comprehension] ' is this good

[faisalalisayyed]

Also a bug / or false positive changelog fragment would be nice for this one.

where to do that in the doc/whatsnew/fragment or any where else and what it would be helpfull thanks!

[jacobtylerwalls]

where to do that in the doc/whatsnew/fragment or any where else and what it would be helpfull thanks!

Check out the contributor docs for some info on documenting your pull request.

[jacobtylerwalls]

Thanks for the news entry! Spotted one typo.

[jacobtylerwalls]

Thanks for the contribution! 🎁

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on sentry:
The following messages are now emitted:

Details

1. unnecessary-comprehension:
   Unnecessary use of a comprehension, use list(self.get_targets()) instead.
   https://github.com/getsentry/sentry/blob/94245776a36896510af2e305a4b121e00a1669aa/src/sentry/incidents/action_handlers.py#L185
2. unnecessary-comprehension:
   Unnecessary use of a comprehension, use list(self.unregistered_options) instead.
   https://github.com/getsentry/sentry/blob/94245776a36896510af2e305a4b121e00a1669aa/src/sentry/runner/commands/presenters/slackpresenter.py#L95

The following messages are no longer emitted:

Details

1. unnecessary-comprehension:
   Unnecessary use of a comprehension, use self.get_targets() instead.
   https://github.com/getsentry/sentry/blob/94245776a36896510af2e305a4b121e00a1669aa/src/sentry/incidents/action_handlers.py#L185
2. unnecessary-comprehension:
   Unnecessary use of a comprehension, use self.unregistered_options instead.
   https://github.com/getsentry/sentry/blob/94245776a36896510af2e305a4b121e00a1669aa/src/sentry/runner/commands/presenters/slackpresenter.py#L95

This comment was generated for commit 1bc8f5e

requested test coverage added