Skip to content

[Backport maintenance/3.0.x] Fix false positive for unnecessary-lambda with kwargs in the call but not the lambda#9200

Merged
Pierre-Sassoulas merged 1 commit into
maintenance/3.0.xfrom
backport-9149-to-maintenance/3.0.x
Oct 29, 2023
Merged

[Backport maintenance/3.0.x] Fix false positive for unnecessary-lambda with kwargs in the call but not the lambda#9200
Pierre-Sassoulas merged 1 commit into
maintenance/3.0.xfrom
backport-9149-to-maintenance/3.0.x

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Backport 2289c71 from #9149.

This simplifies the check for the call having kwargs but not the lambda.

(cherry picked from commit 2289c71)
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Oct 29, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 3.0.3 milestone Oct 29, 2023
@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) October 29, 2023 19:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2023

Codecov Report

Merging #9200 (f34d1dd) into maintenance/3.0.x (53d4541) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##           maintenance/3.0.x    #9200      +/-   ##
=====================================================
+ Coverage              95.76%   95.78%   +0.01%     
=====================================================
  Files                    173      173              
  Lines                  18691    18686       -5     
=====================================================
- Hits                   17900    17898       -2     
+ Misses                   791      788       -3     
Files Coverage Δ
pylint/checkers/base/basic_checker.py 98.08% <100.00%> (+0.21%) ⬆️

... and 1 file with indirect coverage changes

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0273db7 into maintenance/3.0.x Oct 29, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-9149-to-maintenance/3.0.x branch October 29, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

False Positive 🦟 A message is emitted but nothing is wrong with the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants