Fix suggestion for min-max with expressions #9131
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 173 173
Lines 18665 18676 +11
=======================================
+ Hits 17874 17885 +11
Misses 791 791
|
|
Hmm, I think the primer failed because the interpreter changed when we added python 3.12 in #9092 , would you mind rebasing, please ? |
theirix
force-pushed
the
nested-min-max-expr
branch
from
96bf74c to
811d2c0
Compare
This comment has been minimized.
This comment has been minimized.
Thank you!
Rebased the branch. The only failing check is readthedocs. Please tell me if another rebase is needed when the fix is provided. |
|
Outch, I broke the main branch, fixed by #9140, you can rebase π |
theirix
force-pushed
the
nested-min-max-expr
branch
from
811d2c0 to
ee8234a
Compare
|
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit ee8234a |
Closes #8524 (cherry picked from commit ce8d1a9) Co-authored-by: theirix <[email protected]>
Type of Changes
Description
Fixes suggestion when list or dict comprehensions are used or combined with add/or operators.
Closes #8524