Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of using private Qt logic #96

Open
leha-bot opened this issue Feb 1, 2018 · 3 comments
Open

Get rid of using private Qt logic #96

leha-bot opened this issue Feb 1, 2018 · 3 comments
Labels
category:Enhancement This is a proposed improvement category:Help Wanted Volunteers to take this issue are sought after category:Infrastructure Related to build tools, automation
Milestone
Refactoring

Comments

@leha-bot
Copy link
Member

leha-bot commented Feb 1, 2018

It could improve the infrastructure and reduce build complexity.
@leha-bot leha-bot added category:Enhancement This is a proposed improvement category:Help Wanted Volunteers to take this issue are sought after category:Infrastructure Related to build tools, automation labels Feb 1, 2018
@leha-bot leha-bot added this to the Refactoring milestone Feb 1, 2018
@ForNeVeR
Copy link
Member

ForNeVeR commented Feb 1, 2018

I'd recommend to try build the project without Qt private modules and check for the build errors.

@leha-bot
Copy link
Member Author

leha-bot commented Feb 1, 2018 •
edited
Loading

https://github.com/procxx/kepka/search?utf8=%E2%9C%93&q=%22include+private%22

(thanks for @xvitaly for hint)

@Randl
Copy link
Contributor

Randl commented Feb 20, 2018

Randl@7554b45

List of headers:

  • qcoreapplication_p.h
  • qcssparser_p.h
  • qfixed_p.h
  • qfontengine_p.h
  • qfont_p.h
  • qfragmentmap_p.h
  • qglobal_p.h
  • qguiapplication_p.h
  • qharfbuzz_p.h
  • qobject_p.h
  • qplatformnativeinterface.h
  • qshortcutmap_p.h
  • qtextdocument_p.h
  • qtextengine_p.h
  • qtextformat_p.h
  • qtguiglobal_p.h
  • qthread_p.h
  • qtools_p.h
  • qunicodetools_p.h
  • qwindowsysteminterface.h
  • qwindowsysteminterface_p.h

@leha-bot leha-bot mentioned this issue Apr 10, 2018
Open
leha-bot added a commit that referenced this issue Apr 11, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
207a100 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
0849f45 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
56cbcdc 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Jun 4, 2018
@leha-bot
Remove PCH (#148)
6966121 
This commit brings many changes:

1. Remove cotire;
2. Remove PCH files (stdafx.xxx) and mentions;
3. Rearrange and clean includes:
3.1. Remove core includes path, use full header path core/xxx;
3.2. Move object_ptr to separate file base/object_ptr.h;
3.3. Add missing includes;
5. Add forward decls;
6. Get rid of some Qt private parts;
7. Fix ALL compilation errors after removing cotire on Windows, Linux, MacOS.

Closes #133.
Related to #96.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:Enhancement This is a proposed improvement category:Help Wanted Volunteers to take this issue are sought after category:Infrastructure Related to build tools, automation
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
3 participants
@ForNeVeR @Randl @leha-bot