-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cotire, rewrite #include's and fix all compile errors which appeared after cotire removal #148
Conversation
✅ Build kepka 1.0.126-ekebaqjc completed (commit 52d5b47487 by @leha-bot) |
✅ Build kepka 1.0.126-pgksfebp completed (commit f224faa6ee by @leha-bot) |
✅ Build kepka 1.0.126-kpghrbvr completed (commit 499538ebec by @leha-bot) |
✅ Build kepka 1.0.126-bwgcxxao completed (commit f3f43c9351 by @berkus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go, but i'd rearrange/squash several commits before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: cherry-pick one line related to core include paths from my commit and squash with this commit
@@ -18,13 +18,14 @@ to link the code of portions of this program with the OpenSSL library. | |||
Full license: https://github.com/telegramdesktop/tdesktop/blob/master/LICENSE | |||
Copyright (c) 2014-2017 John Preston, https://desktop.telegram.org | |||
*/ | |||
#include <QMouseEvent> | |||
#include "single_timer.h" | |||
#include "core/single_timer.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This string must be squashed into a8e998a
Travis CI used old cache and did not find the compilation errors (instead it that errors has been found by us). Also get rid of some Qt private parts, more fwd decls and so on.
TODO: move out timer-related utils from utils to timer to avoid include bloating |
✅ Build kepka 1.0.129-oqbhvnun completed (commit 08a7294d3a by @) |
This PR drops cotire and broken PCH, and rearrange headers to avoid cycles which has been hidden by PCH.
Also this PR closes #133
CAUTION: Merge only if: