Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of strange bicycle types #27

Open
1 of 9 tasks
leha-bot opened this issue Dec 5, 2017 · 0 comments
Open
1 of 9 tasks

Get rid of strange bicycle types #27

leha-bot opened this issue Dec 5, 2017 · 0 comments
Assignees
@crackedmind @leha-bot
Labels
category:Enhancement This is a proposed improvement category:Good First Issue Try this first if you want to start helping on this project category:Help Wanted Volunteers to take this issue are sought after category:Refactoring Related to code refactoring
Milestone
Refactoring

Comments

@leha-bot
Copy link
Member

leha-bot commented Dec 5, 2017 •
edited
Loading

These headers contains wacky and counter-semantic implementations of some rarely used things. We should replace that stuff:

  • base/weak_unique_ptr.h
  • base/flat_set.h
  • base/flat_map.h
  • base/tests/flat_map_tests.cpp
  • base/type_traits.h
  • base/optional.h
  • base/ordered_set.h — ?
  • dialogs/dialogs_list.h
  • dialogs/dialogs_indexed_list.h
@leha-bot leha-bot added category:Enhancement This is a proposed improvement category:Good First Issue Try this first if you want to start helping on this project category:Help Wanted Volunteers to take this issue are sought after category:Refactoring Related to code refactoring labels Dec 5, 2017
@berkus berkus added this to the Refactoring milestone Jan 18, 2018
leha-bot added a commit that referenced this issue Apr 11, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
207a100 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
0849f45 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
56cbcdc 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
@Randl Randl mentioned this issue Jun 13, 2018
Merged
Randl added a commit to Randl/tdesktop that referenced this issue Jun 14, 2018
@Randl
Minimize type_traits (procxx#27)
b3234fc
@Randl Randl mentioned this issue Jun 14, 2018
Merged
leha-bot pushed a commit that referenced this issue Jun 20, 2018
@Randl @leha-bot
Minimize type_traits (#27)
8b18922
@berkus berkus removed their assignment Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crackedmind crackedmind

@leha-bot leha-bot

Labels
category:Enhancement This is a proposed improvement category:Good First Issue Try this first if you want to start helping on this project category:Help Wanted Volunteers to take this issue are sought after category:Refactoring Related to code refactoring
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
3 participants
@berkus @crackedmind @leha-bot