Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pch usage #16

Open
crackedmind opened this issue Nov 28, 2017 · 1 comment
Open

Improve pch usage #16

crackedmind opened this issue Nov 28, 2017 · 1 comment
Labels
category:Infrastructure Related to build tools, automation category:Metabug Umbrella issue for a series of related tickets
Milestone
Refactoring

Comments

@crackedmind
Copy link
Member

No description provided.

@berkus
Copy link
Member

berkus commented Nov 28, 2017

  • Use IWYU - makes better code
  • Put only system headers in the pch
  • cotire had problems with pch when using sub-directories targets, investigate if using only system headers will make it work correctly.
    • provide an add_pch() macro to set up common stdafx header for sub-targets

@leha-bot leha-bot added the category:Infrastructure Related to build tools, automation label Dec 20, 2017
@leha-bot leha-bot mentioned this issue Jan 17, 2018
Closed
@berkus berkus added this to the Refactoring milestone Jan 18, 2018
@leha-bot leha-bot added the category:Metabug Umbrella issue for a series of related tickets label Mar 10, 2018
@leha-bot leha-bot mentioned this issue Apr 10, 2018
Open
leha-bot added a commit that referenced this issue Apr 11, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
207a100 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 11, 2018
@leha-bot
Reorganize #include's in ui/text/text.cpp
fdf942e 
Now it compiles faster

Related to #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
0849f45 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Reorganize #include's in ui/text/text.cpp
477289d 
Now it compiles faster

Related to #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Get rid of qharfbuzz_p private dependency
56cbcdc 
It's used for weird conversion from "QChar::Script" to internal
HB_Script and back.

Looks like it was in old Qt on this mirror link:
https://git.merproject.org/mer-core/qtbase/commit/39b4955da3afca252dfc58c2a1395446207d89e4?view=parallel

Related to #96 #27 #16
leha-bot added a commit that referenced this issue Apr 17, 2018
@leha-bot
Reorganize #include's in ui/text/text.cpp
ed0e5b9 
Now it compiles faster

Related to #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category:Infrastructure Related to build tools, automation category:Metabug Umbrella issue for a series of related tickets
Projects
None yet
Milestone
Refactoring
Development

No branches or pull requests
3 participants
@berkus @crackedmind @leha-bot