Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lambdas, #164

Merged
merged 3 commits into from
Jul 27, 2018
Merged

Simplify lambdas, #164

merged 3 commits into from
Jul 27, 2018

Conversation

Randl
Copy link
Contributor

@Randl Randl commented Jun 11, 2018

Backport

@crackedmind
Copy link
Member

@Randl
Copy link
Contributor Author

Randl commented Jun 13, 2018

Possibly part of #27

@leha-bot leha-bot added category:Refactoring Related to code refactoring category:Infrastructure Related to build tools, automation labels Jun 20, 2018
@berkus
Copy link
Member

berkus commented Jun 20, 2018

Resolve conflicts?

@crackedmind
Copy link
Member

@leha-bot leha-bot self-requested a review June 27, 2018 11:19
@leha-bot leha-bot added the category:Sync Reduce disparity with upstream code label Jun 29, 2018
Copy link
Member

@leha-bot leha-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please squash commits with one-line descriptions and make the commit message more descriptive for last commit ("Backport ").

@crackedmind
Copy link
Member

Copy link
Member

@leha-bot leha-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crackedmind
Copy link
Member

@Randl Randl dismissed leha-bot’s stale review July 27, 2018 12:46

fixed (for real)

@leha-bot leha-bot merged commit 38efa1b into procxx:dev Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:Infrastructure Related to build tools, automation category:Refactoring Related to code refactoring category:Sync Reduce disparity with upstream code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants