This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add CALLVALUE and CALLDATASIZE#96
Merged
Merged
Conversation
| execution_state=ExecutionState.CALLDATASIZE, | ||
| rw_counter=9, | ||
| call_id=1, | ||
| is_root=True, |
Collaborator
There was a problem hiding this comment.
@ed255 Should we also test the scenario where this is not the root (is_root=False) so that we test CALLDATASIZE for internal calls as well?
Contributor
Author
There was a problem hiding this comment.
I think that's a very interesting case to test. Nevertheless I think we'll have to wait for this #82 to be merged so that we have CALLs in order to achieve a test situation where is_root=False.
So I'd say that we can delay this for the future.
han0110
approved these changes
Jan 20, 2022
ed255
force-pushed
the
feature/opcode-callvalue1
branch
2 times, most recently
from
e435c9a to
5818955
Compare
Also fix rw_table order in CALLER: first call context, then stack op. This makes the circuit closer to the actual EVM behaviour: first the caller_address is obtained from the call context, and then it is pushed to the stack.
ed255
force-pushed
the
feature/opcode-callvalue1
branch
from
5818955 to
2c63675
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix rw_table order in CALLER: first call context, then stack op.
This makes the circuit closer to the actual EVM behaviour: first the
caller_address is obtained from the call context, and then it is pushed
to the stack.