This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Implement circuit for CALLER and CALLVALUE opcode#287
Merged
Conversation
ed255
added
crate-bus-mapping
github-actions
Bot
added
crate-keccak
Contributor
Contributor
Author
Completely agree!
Yes I'd suggest waiting until #279 and #278 is merged before reviewing this PR. I'll remove the draft mode once it's ready for review. |
ed255
force-pushed
the
feature/opcode-caller
branch
from
7c79ae2 to
4cd9863
Compare
ed255
force-pushed
the
feature/opcode-caller
branch
from
4cd9863 to
0e7c179
Compare
ed255
changed the title
78 tasks
ed255
force-pushed
the
feature/opcode-caller
branch
from
0e7c179 to
08ab69e
Compare
github-actions
Bot
removed
crate-zkevm-circuits
ed255
force-pushed
the
feature/opcode-caller
branch
from
08ab69e to
7adc5cc
Compare
Contributor
Author
|
@CPerezz the PR is now ready for review :) |
ed255
changed the title
CPerezz
approved these changes
Feb 18, 2022
Contributor
CPerezz
left a comment
CPerezz
left a comment
There was a problem hiding this comment.
LGTM
Just the const nit for the ADDR_BYTE_LENGTH
ed255
force-pushed
the
feature/opcode-caller
branch
from
7adc5cc to
a51473f
Compare
This was referenced Mar 1, 2022
19 tasks
zemse
pushed a commit
to zemse/zkevm-circuits
that referenced
this pull request
Mar 22, 2023
* many fixes after sync upstream * fixing * limit mainnet test k = 22 * fix CircuitTestBuilder k * revert to upstream test_util * fix k; disable ecdsa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on
geth-utilsandbus-mappingto build more witness #292Based on privacy-ethereum/zkevm-specs#90 and privacy-ethereum/zkevm-specs#96
Take a special look at the approach I've followed to verify the equivalence between caller address in the StackOp (rlc encoded) and the CallContext (raw value) .