Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Gadget for opcode calldatasize#329

Merged
ed255 merged 4 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/op-calldatasize
Feb 23, 2022
Merged

Gadget for opcode calldatasize#329
ed255 merged 4 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/op-calldatasize

Conversation

@scroll-dev
Copy link
Copy Markdown
Collaborator

@github-actions github-actions Bot added crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue labels Feb 10, 2022
@ChihChengLiang
Copy link
Copy Markdown
Collaborator

@roynalnaruto Can we rebase this?

Comment thread bus-mapping/src/evm/opcodes.rs Outdated
Comment thread zkevm-circuits/src/evm_circuit/execution/calldatasize.rs
Comment thread bus-mapping/src/evm/opcodes/calldatasize.rs Outdated
Comment thread zkevm-circuits/src/evm_circuit/execution/calldatasize.rs
Comment thread zkevm-circuits/src/evm_circuit/execution/calldatasize.rs
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work :)

@ed255
Copy link
Copy Markdown
Contributor

ed255 commented Feb 23, 2022

@roynalnaruto this PR needs one last rebase with main and it will be ready to be merged :)

@roynalnaruto
Copy link
Copy Markdown
Collaborator

@roynalnaruto this PR needs one last rebase with main and it will be ready to be merged :)

Done! 👍

@ed255 ed255 merged commit 68111a7 into privacy-ethereum:main Feb 23, 2022
@roynalnaruto roynalnaruto deleted the feat/op-calldatasize branch February 23, 2022 15:08
@CPerezz CPerezz mentioned this pull request Apr 4, 2022
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants