This repository was archived by the owner on Apr 18, 2025. It is now read-only.
CALLDATASIZE Gadget#80
Closed
roynalnaruto wants to merge 9 commits into
Closed
Conversation
5 tasks
roynalnaruto
force-pushed
the
feat/calldatasize
branch
from
b428071 to
f1a33f6
Compare
Author
|
Should make use of |
roynalnaruto
force-pushed
the
feat/calldatasize
branch
from
f1a33f6 to
c2bd2f8
Compare
roynalnaruto
requested review from
0xmountaintop,
DreamWuGit,
icemelon and
lispc
icemelon
previously approved these changes
Jan 31, 2022
| } | ||
|
|
||
| fn tx_context_lookup( | ||
| pub(crate) fn tx_context_lookup( |
Member
There was a problem hiding this comment.
revert this change as it is not required in this PR.
…uits into feat/calldatasize
icemelon
approved these changes
Feb 4, 2022
Member
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
After fix the comment and rebase to latest main, I'll create the PR to upstream.
| // OpcodeId::CALLVALUE => {}, | ||
| // OpcodeId::CALLDATALOAD => {}, | ||
| // OpcodeId::CALLDATASIZE => {}, | ||
| OpcodeId::CALLDATASIZE => CallDataSize::gen_associated_ops, |
Member
There was a problem hiding this comment.
You can now use StackOnlyOpcode as TIMESTAMP opcode is already merged.
Author
There was a problem hiding this comment.
@icemelon rebasing was a mess (because of the merge commit that got through). I'm closing this PR and opening a new one with all the changes from before as well as the changes suggested in the reviews.
Closed
Author
|
Closing in favour of #90 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following specs in Specs PR