feat: upgrade RwTable and add aux

[scroll-dev]

upgrade RwTable layout according to https://hackmd.io/VCGteyZEQFKUjHA_A72f1Q

1. increase RW table column and add aux
2. use fixed position for "value"&"value_prev" for different RW, allowing consistent codes/logic
3. change "TxRefund"&"AccountDestructed" from "write_only_persistent" to "write_with_reversion"
4. update tests

[ed255]

I've taken a look at this PR and I have a question: could you explain which tag in the RW table will use the aux1 and aux2 columns, and what values will be put there? Thanks!

[0xmountaintop]

I've taken a look at this PR and I have a question: could you explain which tag in the RW table will use the aux1 and aux2 columns, and what values will be put there? Thanks!

Hi @ed255! As in https://hackmd.io/VCGteyZEQFKUjHA_A72f1Q#Data-kinds, only AccountStorage will use aux. And:

• aux1 for tx_id
• aux2 for committed_value(original_value_in_tx).

[han0110]

LGTM!

Also want to give some more context on why we remove write_only_persistent: It's a premature optimization for those states (e.g. TxRefund and AccountDestructed) which can't affect future execution, to reduce the amount of reversion write.

But in practice reversion will be costly by ^gas/_rw or ^gas/_step, so we don't need to worry about them. Also such optimization might not be future proof, since we don't know if in the future EVM execution depends on such state or not.

[DreamWuGit]

just one small question, seems value_prev not present in table of page: https://hackmd.io/VCGteyZEQFKUjHA_A72f1Q

[han0110]

The table in the note is for State circuit itself. When it outputs to rw_table, it can get access to value_prev by rotation directly instead of having it in witness in the same row.

[DreamWuGit]

make sense Thx!

[DreamWuGit]

LGTM. Thanks !

[0xmountaintop]

tests fail. need to fix.

[0xmountaintop]

fixed

[ed255]

LGTM!