add sload & sstore specs#26
Closed
0xmountaintop wants to merge 7 commits into
Closed
Conversation
0xmountaintop
force-pushed
the
new_sload_sstore
branch
3 times, most recently
from
dc96f21 to
4a1a18f
Compare
DreamWuGit
reviewed
Jan 19, 2022
| 2. opId === OpcodeId(0x55) for `SSTORE` | ||
| 2. state transition: | ||
| - gc | ||
| - `SLOAD`: +5 (2 stack operations + 1 storage reads + 2 access_list reads/writes) |
There was a problem hiding this comment.
May I know where the 2 access_list reads/writes happen ?
Author
There was a problem hiding this comment.
check the "lookup" section below
DreamWuGit
reviewed
Jan 19, 2022
0xmountaintop
force-pushed
the
new_sload_sstore
branch
from
ddce825 to
2118d2f
Compare
Closed
Author
|
tests fail. need to fix |
0xmountaintop
force-pushed
the
new_sload_sstore
branch
2 times, most recently
from
a160ff6 to
3fdf272
Compare
fix test_sstore
0xmountaintop
force-pushed
the
new_sload_sstore
branch
from
3fdf272 to
77208d0
Compare
* init: increase RwTable size * fix test except begin_tx * fix test_ begin_tx * clean up * lint codes * fix call_context_lookup * fix stack_lookup * update * fix * fix Co-authored-by: HAOYUatHZ <haoyu@protonmail.com> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
|
moved to privacy-ethereum#106 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on privacy-ethereum#94