This repository was archived by the owner on Jul 5, 2024. It is now read-only.
feat: upgrade RwTable and add aux#285
Merged
Merged
Conversation
github-actions
Bot
added
T-opcode
0xmountaintop
force-pushed
the
rw_table/add_aux
branch
from
4c09583 to
32684d8
Compare
This was referenced Jan 18, 2022
icemelon
reviewed
Jan 25, 2022
Comment on lines
+506
to
+511
| RwTableTag::TxAccessListAccount => values.swap(3, 4), | ||
| RwTableTag::TxAccessListStorageSlot => values.swap(3, 4), | ||
| RwTableTag::Account => values.swap(2, 3), | ||
| RwTableTag::Account => values.swap(3, 4), | ||
| RwTableTag::AccountStorage => values.swap(3, 4), | ||
| RwTableTag::AccountDestructed => values.swap(2, 3), | ||
| RwTableTag::AccountDestructed => values.swap(3, 4), | ||
| RwTableTag::TxRefund => values.swap(3, 4), |
Collaborator
There was a problem hiding this comment.
Merge these cases together, like RwTableTag::TxAccessListAccount | RwTableTag::TxAccessListStorageSlot | ...?
Collaborator
There was a problem hiding this comment.
Or maybe add a func fn is_reversible() to RwTableTag?
Collaborator
There was a problem hiding this comment.
no problem! I will work on it
0xmountaintop
force-pushed
the
rw_table/add_aux
branch
from
f77d2fc to
f674018
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to sync with privacy-ethereum/zkevm-specs#94