This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Untrack last_callee_* of StepState#99
Merged
han0110 merged 1 commit intoJan 29, 2022
Merged
Conversation
0xmountaintop
approved these changes
Jan 21, 2022
ed255
reviewed
Jan 27, 2022
Comment on lines
+161
to
+163
| (17, RW.Read, RWTableTag.CallContext, 1, CallContextFieldTag.LastCalleeId, 0, 0, 0), | ||
| (18, RW.Read, RWTableTag.CallContext, 1, CallContextFieldTag.LastCalleeReturnDataOffset, 0, 0, 0), | ||
| (19, RW.Read, RWTableTag.CallContext, 1, CallContextFieldTag.LastCalleeReturnDataLength, 0, 0, 0), |
Contributor
There was a problem hiding this comment.
The current conflict comes because of #94
These tuples now have 10 elements, so they require 2 extra trailing zeroes.
han0110
force-pushed
the
feature/untrack-last-callee-info
branch
from
a4e7240 to
28827d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is once part of #82, and aims to move the tracking of
last_callee_*torw_tablefor simplicity.