This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Find and replace state_write_counter with reversible_write_counter#185
Merged
Conversation
han0110
reviewed
Apr 14, 2022
Contributor
han0110
left a comment
han0110
left a comment
There was a problem hiding this comment.
I also did the same thing in #100, but it's nice to do this in a separate PR. (btw for circuit, I updated the naming in privacy-ethereum/zkevm-circuits#419.)
Contributor
Author
Great minds think alike: privacy-ethereum/zkevm-circuits@a9bdc9a I am renaming state write -> reversible write in https://github.com/appliedzkp/zkevm-docs too. |
han0110
approved these changes
Apr 15, 2022
Contributor
han0110
left a comment
han0110
left a comment
There was a problem hiding this comment.
Ah I didn't see that you already planed to fix it in spec and in doc. All renaming look good to me now!
ed255
approved these changes
Apr 27, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the update!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to privacy-ethereum/zkevm-circuits#409