This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Spec ExecutionState::STOP#100
Merged
Merged
Conversation
ed255
approved these changes
Jan 27, 2022
ed255
suggested changes
Jan 27, 2022
78 tasks
han0110
force-pushed
the
feature/stop
branch
2 times, most recently
from
1e49331 to
19f2da3
Compare
6 tasks
ed255
approved these changes
Apr 27, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
I've left two small comments but everything looks correct to me :)
I'm approving the PR already, feel free to check the comments and discuss!
Contributor
|
BTW, the current branch conflicts seem to come from #185 and should be very easy to resolve. |
29 tasks
48 tasks
icemelon
reviewed
Jun 29, 2022
Collaborator
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
LGTM. Just two minor comments.
icemelon
approved these changes
Jun 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to spec out
ExecutionState::STOP.TODO
STOPwhenprogram_counter == code.length(discussion in Retrieve codelength#102).