This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Implementation ExecutionState::STOP#419
Merged
Merged
Conversation
github-actions
Bot
added
crate-bus-mapping
This was referenced Apr 6, 2022
11 tasks
This was referenced Apr 12, 2022
github-actions
Bot
removed
crate-keccak
This was referenced May 4, 2022
48 tasks
ed255
reviewed
Jun 23, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
First review round. I'm missing review of:
zkevm-circuits/src/evm_circuit/step.rszkevm-circuits/src/evm_circuit/util/common_gadget.rszkevm-circuits/src/evm_circuit/witness.rs
Overall looks good! I've added minor comments and suggestions.
DreamWuGit
reviewed
Jul 4, 2022
DreamWuGit
reviewed
Jul 4, 2022
DreamWuGit
approved these changes
Jul 4, 2022
Collaborator
DreamWuGit
left a comment
DreamWuGit
left a comment
There was a problem hiding this comment.
LGTM, only left some classifications!
zemse
pushed a commit
to zemse/zkevm-circuits
that referenced
this pull request
Mar 22, 2023
* Implement circuit for `ErrorOutOfGasSHA3` state. * Add `MemoryExpandedAddressGadget` to support memory offset plus length greater than `0x1FFFFFFFE0`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implement
ExecutionState::STOP. For spec, please refer to privacy-ethereum/zkevm-specs#100.It also resolves #464 by removing the incomplete trace testing used in
COPYTOMEMORYandCOPYCODETOMEMORYbecause they should be covered byCALLDATACOPYandCODECOPY.TODO
Broken tests
Currently some of tests using hand-crafted testing witness (instead of using
CircuitInputBuilder) are failed by this PR, those unfixed include:CALLDATACOPYCALLDATALOAD- CALLDATALOAD: bus-mapping and refactoring #402CALLDATASIZE- Fix some bugs ofCircuitInputBuilder#434MEMORY_COPYSLOAD,SSTORE- feat: bus mapping for sload and sstore #418Opcode fetching out of range
STOPcan be fully implemented