Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

Rename "state write" to "reversible write"#409

Merged
ChihChengLiang merged 3 commits into
privacy-ethereum:mainfrom
scroll-tech:fix/rename
Apr 6, 2022
Merged

Rename "state write" to "reversible write"#409
ChihChengLiang merged 3 commits into
privacy-ethereum:mainfrom
scroll-tech:fix/rename

Conversation

@z2trillion
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue labels Mar 25, 2022
Copy link
Copy Markdown
Contributor

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@z2trillion Would you like to update https://github.com/appliedzkp/zkevm-specs and https://github.com/appliedzkp/zkevm-docs/ as well? (they contain several references to state_write_counter)

Copy link
Copy Markdown
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChihChengLiang
Copy link
Copy Markdown
Collaborator

@z2trillion This PR is mergeable, but it needs a rebase.

@z2trillion z2trillion requested review from a team and miha-stopar and removed request for a team April 5, 2022 21:33
@z2trillion
Copy link
Copy Markdown
Contributor Author

LGTM!

@z2trillion Would you like to update https://github.com/appliedzkp/zkevm-specs and https://github.com/appliedzkp/zkevm-docs/ as well? (they contain several references to state_write_counter)

Will do

Copy link
Copy Markdown
Collaborator

@miha-stopar miha-stopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member T-opcode Type: opcode-related and focused PR/Issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants