This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Tx logs buss mapping#476
Merged
Merged
Conversation
github-actions
Bot
added
crate-bus-mapping
DreamWuGit
force-pushed
the
tx_logs_bussmapping
branch
from
14516b2 to
215fe62
Compare
github-actions
Bot
added
the
crate-eth-types
DreamWuGit
force-pushed
the
tx_logs_bussmapping
branch
from
270e027 to
1ca75c2
Compare
This was referenced May 12, 2022
DreamWuGit
force-pushed
the
tx_logs_bussmapping
branch
from
d7a9192 to
30b4780
Compare
DreamWuGit
force-pushed
the
tx_logs_bussmapping
branch
from
30b4780 to
66a6a39
Compare
Collaborator
Author
|
@ed255 @miha-stopar could you pls. have a look ? Thx ! |
ed255
reviewed
Jun 1, 2022
icemelon
approved these changes
Jun 4, 2022
Collaborator
icemelon
left a comment
icemelon
left a comment
There was a problem hiding this comment.
LGTM. just one minor comment
Collaborator
|
@ed255 could you take another look? |
ed255
approved these changes
Jun 7, 2022
Contributor
ed255
left a comment
ed255
left a comment
There was a problem hiding this comment.
LGTM! Thanks for addressing my comments :)
davidnevadoc
pushed a commit
to davidnevadoc/zkevm-circuits
that referenced
this pull request
Jun 8, 2022
* rebase to main and replace log cirucit with bussmapping * modi single circuit step&pass * add multi log steps test * rebase to main and minor update * fix index lookup and tag overlap issue * refactor txlog write op style and tests * fix comment * enable commented tests * fix ci test error * fix comment line * minor updates * fix comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.