This repository was archived by the owner on Jul 5, 2024. It is now read-only.

implement log state circuit #552

Merged

ed255 merged 18 commits into

privacy-ethereum:mainfrom

scroll-tech:log_state

Jun 30, 2022

Collaborator

DreamWuGit commented Jun 3, 2022 •

edited

Loading

change list:

add is_field_tag_unchanged_column in state circuit for check field_tag diff
add tx log constraint for state part
add part of positive and negative tests
fix address expression in fix address expression for log #581

github-actions Bot added crate-bus-mapping crate-eth-types crate-zkevm-circuits labels

DreamWuGit force-pushed the log_state branch from 503cb38 to a73b56b Compare

June 8, 2022 08:50

github-actions Bot removed crate-bus-mapping crate-eth-types labels

DreamWuGit marked this pull request as ready for review

June 8, 2022 09:04

DreamWuGit requested a review from miha-stopar as a code owner

June 8, 2022 09:04

icemelon mentioned this pull request

Add missing constraints to state circuit #551

Closed

9 tasks

lispc reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

lispc reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

lispc reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

lispc reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

lispc reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs

DreamWuGit mentioned this pull request

revise log state constrain according to circuit implementation privacy-ethereum/zkevm-specs#220

Merged

Collaborator Author

DreamWuGit commented Jun 13, 2022

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

Collaborator

miha-stopar commented Jun 13, 2022

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

Yes, sure, just started today. One question before I dive deeper - are there some specs corresponding to this PR?

Collaborator Author

DreamWuGit commented Jun 13, 2022

@ed255 or @miha-stopar Could you pls. have a look ? Thx !!

Yes, sure, just started today. One question before I dive deeper - are there some specs corresponding to this PR?

@miha-stopar privacy-ethereum/zkevm-specs#220 is related spec PR :)

z2trillion mentioned this pull request

State Circuit Tracker #568

Closed

15 tasks

DreamWuGit mentioned this pull request

Use BinaryNumberChip in LexicographicOrderingConfig to lower degree #566

Merged

Contributor

ed255 commented Jun 15, 2022

@z2trillion since you're also working on the state circuit I think it would be good if you can take a look at this PR :)

ed255 reviewed

View reviewed changes

zkevm-circuits/src/state_circuit.rs Outdated

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

zkevm-circuits/src/state_circuit/constraint_builder.rs

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

miha-stopar reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

zkevm-circuits/src/state_circuit/constraint_builder.rs

DreamWuGit force-pushed the log_state branch 2 times, most recently from a4c188b to c3aa98e Compare

June 22, 2022 12:55

DreamWuGit mentioned this pull request

fix address expression for log #581

Closed

DreamWuGit force-pushed the log_state branch from 0df9cf7 to 2f8e932 Compare

June 24, 2022 01:36

icemelon reviewed

View reviewed changes

zkevm-circuits/src/evm_circuit/util/constraint_builder.rs Outdated

icemelon reviewed

View reviewed changes

zkevm-circuits/src/evm_circuit/table.rs


          test pass for positive and negativ

d6a964a

DreamWuGit added 10 commits

June 28, 2022 17:23


          fix ci and increase degree

6ac600e


          disable test affected by issue #561

bc7806d


          add is_tag_unchanged to reduce degree

b7b528b


          constrain log id not change within tx if field tag != Address

8bc794f


          move index constrains out of tx id remain condition

768426e


          merge fixing address expression for log

aa55220


          rebase and fix comment

7fc5785


          fix pre limbs

fcbb714


          remove field tag specific constrain to simplify

8b3b4f7


          log_state

e5433c6

DreamWuGit force-pushed the log_state branch from 2f8e932 to e5433c6 Compare

June 28, 2022 14:25

icemelon reviewed

View reviewed changes

zkevm-circuits/src/state_circuit/constraint_builder.rs Outdated

zkevm-circuits/src/evm_circuit/util/constraint_builder.rs


          fix ci

37fa0d2

DreamWuGit force-pushed the log_state branch from d243360 to 37fa0d2 Compare

June 29, 2022 02:55

DreamWuGit added 2 commits

June 29, 2022 11:08


          Merge branch 'main' into log_state

84ca217


          revise comment as suggestion

icemelon approved these changes

View reviewed changes

Collaborator

icemelon left a comment

LGTM.

@miha-stopar @ed255 do you want to take another look?

Collaborator

miha-stopar commented Jun 29, 2022

LGTM.

@miha-stopar @ed255 do you want to take another look?

LGTM!

miha-stopar approved these changes

View reviewed changes

z2trillion approved these changes

View reviewed changes


          Empty-Commit

808ef0b

ed255 approved these changes

View reviewed changes

Contributor

ed255 left a comment

LGTM!

Please @z2trillion / @miha-stopar can you check the corresponding spec and approve it as well if you see fit?

DreamWuGit added 3 commits

June 29, 2022 21:47


          Merge branch 'main' into log_state

fb9a91d


          Merge branch 'main' into log_state

922c659


          Empty-Commit

15deb72

ed255 merged commit d3c6769 into privacy-ethereum:main

DreamWuGit mentioned this pull request

implement tx log state circuit part #546

Closed

icemelon deleted the log_state branch

June 30, 2022 18:23

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

5 more reviewers

lispc lispc left review comments

miha-stopar miha-stopar approved these changes

icemelon icemelon approved these changes

z2trillion z2trillion approved these changes

ed255 ed255 approved these changes

Labels

crate-zkevm-circuits