This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix multi copy step data index#510
Merged
icemelon merged 7 commits intoMay 23, 2022
Merged
Conversation
fdf8c88 to
e8253bb
Compare
This was referenced May 16, 2022
Merged
z2trillion
reviewed
May 17, 2022
icemelon
reviewed
May 17, 2022
icemelon
left a comment
Collaborator
There was a problem hiding this comment.
should add a test case that could cover the new fix code
0106092 to
b48580d
Compare
Collaborator
Author
tests of |
ed255
reviewed
May 18, 2022
f7c8b38 to
e592c5e
Compare
ed255
approved these changes
May 19, 2022
ed255
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks for the fix :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR can be part of #476 when doing multiple copy step in buss mapping , for
TxLogFieldTag::Dataindex should start from zero and consecutively increasing in multi copy log steps. i.e. total copies size is 66 bytes, data index should be monotone increasing by 1 from 0 across all three copy steps.while old is as below though
Datavalue is correct !found in issue #511