This repository was archived by the owner on Jul 5, 2024. It is now read-only.
fix log gas by adding static cost#507
Merged
Merged
Conversation
DreamWuGit
requested review from
a team and
CPerezz
and removed request for
a team
github-actions
Bot
added
the
crate-zkevm-circuits
ChihChengLiang
requested review from
a team and
han0110
and removed request for
a team and
CPerezz
lispc
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Update `CreateGadget` to limit maximum init code size, and add init code word gas. * Update for oog-create errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when handling #476 , found that
SameContextGadget::constructwon't add op code constant gas into gas cost now, this PR adds log static gas in op code for now.!while in spec
instruction::step_state_transition_in_same_contextstill sum constant and dynamic gas. https://github.com/appliedzkp/zkevm-specs/blob/master/src/zkevm_specs/evm/instruction.py#L245