This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Add spec for CALLER opcode#90
Merged
Merged
Conversation
c27b6e7 to
fd68f5f
Compare
Contributor
The address from call context will always be verified by the step that triggers the call (e.g.
Option b. sounds better IMHO, since we read the call context first, and do a base conversion (from |
fd68f5f to
2740c8e
Compare
2740c8e to
42d01e1
Compare
Contributor
Author
I've updated the spec to follow option b, and removed the notes about checking the address byte length. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have followed the pattern from #83 but using the CallContext in the rw_table instead of the Block table for the value lookup.
Related issue: #86
I've added two questions for doubts I had: