This repository was archived by the owner on Jul 5, 2024. It is now read-only.
[CREATE Part A] Modification to Copy Circuit#1356
Closed
roynalnaruto wants to merge 3 commits into
Closed
Conversation
github-actions
Bot
added
crate-mock
This was referenced Apr 14, 2023
hero78119
reviewed
Apr 17, 2023
| let (caller_id, address, reversion_info, code_hash, init_code_rlc) = | ||
| cb.condition(is_contract_deployment.clone(), |cb| { | ||
| // We don't need to place any additional constraints on code_hash because the | ||
| // copy circuit enforces that it is the hash of the bytes in the copy lookup. |
Contributor
There was a problem hiding this comment.
since intruduce init_code_rlc i think the comment also need to adjust a bit.
Contributor
There was a problem hiding this comment.
Not sure what comment I should add. Could you provide an example?
| /// The value copied in this copy step. | ||
| pub value: Column<Advice>, | ||
| /// Random linear combination accumulator value. | ||
| pub value_acc: Column<Advice>, |
Contributor
There was a problem hiding this comment.
Can we rename value_acc into value_keccak_acc for more self-explanation
Contributor
There was a problem hiding this comment.
I would prefer to rename to value_acc_rlc. Most of our code and docs are using _rlc as suffix to represent rlc variables and it looks good to me without keyword, keccak.
| cb.gate(meta.query_fixed(q_enable, Rotation::cur())) | ||
| }); | ||
|
|
||
| meta.create_gate( |
Contributor
There was a problem hiding this comment.
Seems this gate and next gate can be combine into just 1 gate ?
| cb.gate(and::expr([ | ||
| meta.query_fixed(q_enable, Rotation::cur()), | ||
| meta.query_advice(is_last, Rotation::next()), | ||
| and::expr([ |
Contributor
There was a problem hiding this comment.
Here nested and::expr seems unnessarary, is it for readibility?
Contributor
There was a problem hiding this comment.
agree, I don't think we need it, but it has better readability for me. I prefer to keep the way it is. How do you think?
Contributor
|
Also raise privacy-ethereum/zkevm-specs#411 to align copy-circuit specs |
han0110
reviewed
Apr 19, 2023
This was referenced Apr 28, 2023
Closed
5 tasks
1 task
1 task
4 tasks
Contributor
|
Moved to #1419 |
KimiWu123
added a commit
that referenced
this pull request
May 25, 2023
### Description NOTE: This is an updated version of #1356 This is Part A of a 3 part pull request to add support for `CREATE`/`CREATE2` opcodes. Part A: #1356 Part B: #1357 Part C: #1358 ### Issue Link #1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents As part of the bigger additions needed for the `CREATE`/`CREATE2` opcodes' gadget, this PR adds support for the copy circuit to "always" have a value accumulator field `value_acc`. ### Rationale We need a value accumulator (of the random linear combination) in order to get the `RLC(bytes)` for the bytes copied from `Memory` to `Bytecode` (specifically the init code). This RLC is later used to do a lookup to the Keccak table to check the value of `keccak256(init_code)`. ### How Has This Been Tested? The existing tests for copy circuit pass for the updated constraints on the copy circuit. --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com> Co-authored-by: KimiWu <leonhartwu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is Part A of a 3 part pull request to add support for
CREATE/CREATE2opcodes.Part A: #1356
Part B: #1357
Part C: #1358
Issue Link
#1130
Type of change
Contents
As part of the bigger additions needed for the
CREATE/CREATE2opcodes' gadget, this PR adds support for the copy circuit to "always" have a value accumulator fieldvalue_acc.Rationale
We need a value accumulator (of the random linear combination) in order to get the
RLC(bytes)for the bytes copied fromMemorytoBytecode(specifically the init code). This RLC is later used to do a lookup to the Keccak table to check the value ofkeccak256(init_code).How Has This Been Tested?
The existing tests for copy circuit pass for the updated constraints on the copy circuit.