This repository was archived by the owner on Jul 5, 2024. It is now read-only.
gadget for CREATE(2)#981
Closed
z2trillion wants to merge 73 commits into
Closed
Conversation
github-actions
Bot
added
crate-bus-mapping
github-actions
Bot
added
crate-integration-tests
z2trillion
force-pushed
the
feat/create
branch
from
40d00a5 to
2fa4cb5
Compare
github-actions
Bot
removed
crate-gadgets
lispc
reviewed
Jan 16, 2023
| // and code_hash. Each sequence of bytes occurs in a fixed position, so to | ||
| // compute the RLC of the input, we only need to compute some fixed powers of | ||
| // the randomness. | ||
| let randomness_raised_to_16 = cb.power_of_randomness()[15].clone(); |
Collaborator
There was a problem hiding this comment.
it seems the rlc here assumes randomness of evm_word be equal to randomness of keccak_input? it will be incorrect after the evm circuit challenge api refactor
Collaborator
|
another issue is after #1046, some codes in this PR may also need to be updated. |
lispc
reviewed
Jan 19, 2023
| } | ||
|
|
||
| pub(crate) fn construct_2(cb: &mut ConstraintBuilder<F>) -> Self { | ||
| let offset = cb.query_cell(); |
lispc
reviewed
Jan 19, 2023
| }) | ||
| }); | ||
|
|
||
| let keccak_input = cb.query_cell(); |
Contributor
|
Very excited to see this merged 🥇 ! |
Collaborator
|
@roynalnaruto will work on this issue now |
lispc
reviewed
Feb 23, 2023
|
|
||
| let mut exec_step = state.new_step(geth_step)?; | ||
|
|
||
| let callee = state.parse_call(geth_step)?; |
Collaborator
There was a problem hiding this comment.
the above line "let mut exec_step = state.new_step(geth_step)?;" should be put before memory expansion. Or mem_size inside exec_step will be incorrect
Collaborator
|
CallContext Value should also be written with state.call_context_write. Missing? |
Collaborator
|
@roynalnaruto this PR is relatively outdated with upstream changes. I made some updates in scroll-stable fork, at least it can. pass tests. You can have a look |
lispc
reviewed
Mar 8, 2023
| } else { | ||
| 0 | ||
| }) | ||
| .into(), |
Collaborator
There was a problem hiding this comment.
read the gas_left from rw, then debug_assert_eq
lispc
reviewed
Mar 8, 2023
| state.block.sha3_inputs.push(keccak_input); | ||
|
|
||
| if length == 0 { | ||
| state.handle_return(geth_step)?; |
Collaborator
There was a problem hiding this comment.
handle_restore_context? or write CallContextField::LastCalleeId/CallContextField::LastCalleeReturnDataOffset/CallContextField::LastCalleeReturnDataLength?
Collaborator
|
CallContext Value fixed in scroll-stable branch |
Collaborator
Collaborator
|
Yes |
noel2004
pushed a commit
to noel2004/zkevm-circuits
that referenced
this pull request
Nov 29, 2023
* construct Address direct * aggressive inline hotspot * cache key * don't sort for from_rws_with_mock_state_roots * mark possible optimization * wrap error string with arc * Revert "wrap error string with arc" This reverts commit ad05aff. * exclude original_rws for release build * [wip] reduce clone in ccc path (privacy-ethereum#973) * estimate_circuit_capacity take BlockTrace ownership * Convert ExecutionResult with explicit clone * add block_trace_to_witness_block * construct from ref * sync default mod * fix order * clippy * assertion * dirty fix * extract common * clippy && fmt * fix clippy * async drop (privacy-ethereum#981) * skip small drop * add comments * fix typo --------- Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.