This repository was archived by the owner on Jul 5, 2024. It is now read-only.
[CREATE Part C] bus-mapping and gadget implementation#1358
Closed
roynalnaruto wants to merge 5 commits into
Closed
[CREATE Part C] bus-mapping and gadget implementation#1358roynalnaruto wants to merge 5 commits into
roynalnaruto wants to merge 5 commits into
Conversation
github-actions
Bot
added
crate-bus-mapping
4 tasks
roynalnaruto
changed the title
4 tasks
5 tasks
1 task
1 task
4 tasks
4 tasks
KimiWu123
added a commit
that referenced
this pull request
May 25, 2023
### Description NOTE: This is an updated version of #1356 This is Part A of a 3 part pull request to add support for `CREATE`/`CREATE2` opcodes. Part A: #1356 Part B: #1357 Part C: #1358 ### Issue Link #1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents As part of the bigger additions needed for the `CREATE`/`CREATE2` opcodes' gadget, this PR adds support for the copy circuit to "always" have a value accumulator field `value_acc`. ### Rationale We need a value accumulator (of the random linear combination) in order to get the `RLC(bytes)` for the bytes copied from `Memory` to `Bytecode` (specifically the init code). This RLC is later used to do a lookup to the Keccak table to check the value of `keccak256(init_code)`. ### How Has This Been Tested? The existing tests for copy circuit pass for the updated constraints on the copy circuit. --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com> Co-authored-by: KimiWu <leonhartwu@gmail.com>
Contributor
|
moved to #1430 |
KimiWu123
added a commit
that referenced
this pull request
Jun 9, 2023
### Description NOTE: This is an updated version of #1358 This PR is actually based on top of #1425 ### Issue Link #1130 ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ### Contents Bus mapping implementation for CREATE/CREATE2 EVM circuit's gadget for CREATE/CREATE2 ### How Has This Been Tested? Tests can be found here: https://github.com/scroll-tech/zkevm-circuits/blob/2d2bfc6ccf179ade1a8d063f9586b93e5283a557/zkevm-circuits/src/evm_circuit/execution/create.rs#L678 --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part C
This PR is based on Part B (#1357)
Part B is based on Part A (#1356)
The commits to be reviewed are:
Issue Link
#1130
Type of change
Contents
How Has This Been Tested?
Tests can be found here: https://github.com/scroll-tech/zkevm-circuits/blob/2d2bfc6ccf179ade1a8d063f9586b93e5283a557/zkevm-circuits/src/evm_circuit/execution/create.rs#L678