Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

CREATE/CREATE2 opcode gadget#1355

Closed
roynalnaruto wants to merge 4 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/create-create2-op
Closed

CREATE/CREATE2 opcode gadget#1355
roynalnaruto wants to merge 4 commits into
privacy-ethereum:mainfrom
scroll-tech:feat/create-create2-op

Conversation

@roynalnaruto
Copy link
Copy Markdown
Collaborator

Description

This PR implements the gadget for CREATE and CREATE2 opcodes.

Issue Link

[link issue here]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Contents

  • [item]

Rationale

[design decisions and extended information]

How Has This Been Tested?

[explanation]


How to fill a PR description

Please give a concise description of your PR.

The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.

MUST: Reference the issue to resolve

Single responsability

Is RECOMMENDED to create single responsibility commits, but not mandatory.

Anyway, you MUST enumerate the changes in a unitary way, e.g.

This PR contains:
- Cleanup of xxxx, yyyy
- Changed xxxx to yyyy in order to bla bla
- Added xxxx function to ...
- Refactored ....

Design choices

RECOMMENDED to:

  • What types of design choices did you face?
  • What decisions you have made?
  • Any valuable information that could help reviewers to think critically

@github-actions github-actions Bot added crate-bus-mapping Issues related to the bus-mapping workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member labels Apr 13, 2023
@roynalnaruto roynalnaruto changed the title squashed commits (debugging) CREATE/CREATE2 opcode gadget Apr 13, 2023
@roynalnaruto roynalnaruto mentioned this pull request Apr 13, 2023
4 tasks
@roynalnaruto
Copy link
Copy Markdown
Collaborator Author

@hero78119 created a draft PR. At the moment my changes are squashed into a single commit because those changes introduced a bug in the return_revert gadget. Once debugging is complete, I will split the changes into commits that are reviewer-friendly.

@lispc you could take a look into this PR as well?

@github-actions github-actions Bot added crate-external-tracer Issues related to the external-tracer workspace member crate-mock Issues related to the mock workspace member labels Apr 14, 2023
@lispc lispc marked this pull request as ready for review April 14, 2023 03:55
Copy link
Copy Markdown
Collaborator

@lispc lispc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation looks good for me. But i am considering split this into smaller PRs. Eg: a copy circuit PR and an execution part PR.

@roynalnaruto
Copy link
Copy Markdown
Collaborator Author

@lispc Yes, I will split it into multiple PRs. Was waiting for the return revert gadget's bug to be fixed. Will refactor today

@roynalnaruto
Copy link
Copy Markdown
Collaborator Author

roynalnaruto commented Apr 14, 2023

Closing this in favour of multiple PRs, making the overall changes more review friendly:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

crate-bus-mapping Issues related to the bus-mapping workspace member crate-external-tracer Issues related to the external-tracer workspace member crate-mock Issues related to the mock workspace member crate-zkevm-circuits Issues related to the zkevm-circuits workspace member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants