This repository was archived by the owner on Jul 5, 2024. It is now read-only.
Feat/create create2#1338
Closed
roynalnaruto wants to merge 6 commits into
Closed
Conversation
github-actions
Bot
added
crate-zkevm-circuits
roynalnaruto
force-pushed
the
feat/create-create2
branch
from
a6fa23a to
f828c21
Compare
lispc
reviewed
Apr 2, 2023
| cb.stack_pop(init_code.offset_rlc()); | ||
| cb.stack_pop(init_code.length_rlc()); | ||
| cb.condition(IS_CREATE2.expr(), |cb| { | ||
| cb.stack_pop(create.salt_rlc()); |
Collaborator
There was a problem hiding this comment.
"salt_rlc" here is keccak rlc, not word rlc. Line100 is wrong.
lispc
reviewed
Apr 2, 2023
| MemoryAddressGadget::construct(cb, init_code_memory_offset, init_code_length); | ||
|
|
||
| let keccak_output = cb.query_word_rlc(); | ||
| let new_address_rlc = cb.word_rlc::<N_BYTES_MEMORY_ADDRESS>( |
Collaborator
There was a problem hiding this comment.
N_BYTES_MEMORY_ADDRESS is 5, should be 20 here?
Contributor
|
Hi @roynalnaruto , is this pr ready to review or still got some ongoing tasks? |
Collaborator
Author
|
@hero78119 I will create a new pull request with the updated changes. Those changes were recently merged in Scroll's fork and include the handling of insufficient caller balance. |
Collaborator
Author
|
Closing this in favour of #1355 |
cameron1024
pushed a commit
to cameron1024/zkevm-circuits
that referenced
this pull request
Jun 30, 2024
* add trace jsons to testdata * update mainnet fork height; remove version field in trace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[PR description]
Issue Link
#1130
Type of change
Contents
Rationale
[design decisions and extended information]
How Has This Been Tested?
[explanation]
How to fill a PR description
Please give a concise description of your PR.
The target readers could be future developers, reviewers, and auditors. By reading your description, they should easily understand the changes proposed in this pull request.
MUST: Reference the issue to resolve
Single responsability
Is RECOMMENDED to create single responsibility commits, but not mandatory.
Anyway, you MUST enumerate the changes in a unitary way, e.g.
Design choices
RECOMMENDED to: