Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node version and GH actions in workflows #947

Merged
merged 3 commits into from
May 10, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented May 9, 2023

Closes #946

Octicons are failed to be publish to NPM due to an error while fetching the docker image to build nodes.

Apparently Debian 9/stretch moved to archive.debian.org (reference)

Found through this thread: https://unix.stackexchange.com/questions/743839/apt-get-update-failed-to-fetch-debian-amd64-packages-while-building-dockerfile-f

Also updating all other node versions and GH actions.

@broccolinisoup broccolinisoup requested a review from a team as a code owner May 9, 2023 06:05
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023

⚠️ No Changeset found

Latest commit: 93d92b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,4 +1,4 @@
FROM node:10-slim
FROM node:20-slim
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use node 18 to match Primer React: https://github.com/primer/react/blob/332a1af7d1e961e90a6be198b5b238d843dfad3d/.github/workflows/deploy_preview.yml#L28

Suggested change
FROM node:20-slim
FROM node:18-slim

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the node-version in these workflows:

https://github.com/primer/octicons/blob/main/.github/workflows/publish.yml#L12

node-version: 14.x

node-version: 14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colebemis! I updated all node versions and also the github actions (like checkout, setup-node etc) from v2 to v3

Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

@broccolinisoup broccolinisoup changed the title Update the docker image for building nodes Update the node version and GH actions in workflows May 10, 2023
@broccolinisoup broccolinisoup merged commit 1ee8902 into main May 10, 2023
@broccolinisoup broccolinisoup deleted the update-docker-image branch May 10, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] @primer/octicons-react v19.0.0 not published
3 participants