Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the node version and GH actions in workflows #947

Merged
merged 3 commits into from
May 10, 2023
Merged

Update the node version and GH actions in workflows #947

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
172248a
Update the docker image for building nodes
broccolinisoup May 9, 2023
8f5aa93
Update node versions and GH actions
broccolinisoup May 9, 2023
93d92b7
Merge branch 'main' into update-docker-image
broccolinisoup May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build_node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:10-slim
FROM node:20-slim
broccolinisoup marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use node 18 to match Primer React: https://github.com/primer/react/blob/332a1af7d1e961e90a6be198b5b238d843dfad3d/.github/workflows/deploy_preview.yml#L28

Suggested change
FROM node:20-slim
FROM node:18-slim

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the node-version in these workflows:

https://github.com/primer/octicons/blob/main/.github/workflows/publish.yml#L12

octicons/.github/workflows/release.yml

Line 24 in 4f0c6b4

node-version: 14.x

octicons/.github/workflows/ci.yml

Line 15 in 4f0c6b4

node-version: 14

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colebemis! I updated all node versions and also the github actions (like checkout, setup-node etc) from v2 to v3


RUN apt-get update && \
apt-get install --no-install-recommends -y \
Expand Down