Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node version and GH actions in workflows #947

Merged
merged 3 commits into from
May 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/build_node/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:10-slim
FROM node:18-slim

RUN apt-get update && \
apt-get install --no-install-recommends -y \
Expand Down
44 changes: 22 additions & 22 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,15 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: yarn
- name: Building
run: yarn build
- run: cp -r icons lib/build/svg
- uses: actions/upload-artifact@v2
- uses: actions/upload-artifact@v3
with:
name: octicons-build
path: ./lib/build
Expand All @@ -27,11 +27,11 @@ jobs:
needs: build
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- uses: actions/download-artifact@v2
node-version: 18
- uses: actions/download-artifact@v3
with:
name: octicons-build
path: ./lib/build
Expand All @@ -49,11 +49,11 @@ jobs:
run:
working-directory: ./lib/octicons_node
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- uses: actions/download-artifact@v2
node-version: 18
- uses: actions/download-artifact@v3
with:
name: octicons-build
path: ./lib/build
Expand All @@ -73,11 +73,11 @@ jobs:
run:
working-directory: ./lib/octicons_react
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 14
- uses: actions/download-artifact@v2
node-version: 18
- uses: actions/download-artifact@v3
with:
name: octicons-build
path: ./lib/build
Expand All @@ -97,12 +97,12 @@ jobs:
run:
working-directory: ./lib/octicons_gem
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v3
with:
name: octicons-build
path: ./lib/octicons_gem/lib/build
Expand All @@ -126,12 +126,12 @@ jobs:
run:
working-directory: ./lib/octicons_helper
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v3
with:
name: octicons-gem
path: ./lib/octicons_helper/vendor/cache
Expand All @@ -149,12 +149,12 @@ jobs:
run:
working-directory: ./lib/octicons_jekyll
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.7
- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v3
with:
name: octicons-gem
path: ./lib/octicons_jekyll/vendor/cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-node@master
with:
node-version: '10.x'
node-version: '18.x'
- run: npm install
- run: npm run build
- run: cp -r icons lib/build/svg
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0
persist-credentials: false

- name: Set up Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 14.x
node-version: 18.x

- name: Setup Ruby
uses: ruby/setup-ruby@v1
Expand Down