[native] Introduce module presto-native-tests#24234

Merged

pramodsatya merged 2 commits intoprestodb:masterfrom

pramodsatya:add_native_tests

Mar 26, 2025

Contributor

pramodsatya commented Dec 10, 2024 •

edited by aditi-pandit

Loading

Description

Introduces module presto-native-tests to run end-to-end tests with Presto native workers. Adds Github action to run these tests.

Motivation and Context

Improves Presto native test coverage by extending product tests from presto-tests module to use the native worker. For full context please refer to #23671.

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

== RELEASE NOTES ==
General Changes
* Introduces module presto-native-tests to run end-to-end tests with Presto native workers.

pramodsatya requested a review from aditi-pandit

December 10, 2024 15:25

pramodsatya requested review from a team, elharo, feilong-liu, jaystarshot, steveburnett and vivek-bharathan as code owners

December 10, 2024 15:25

pramodsatya requested a review from presto-oss

December 10, 2024 15:25

prestodb-ci added the from:IBM label

prestodb-ci requested review from a team and ScrapCodes and removed request for a team

December 10, 2024 15:25

pramodsatya force-pushed the add_native_tests branch 2 times, most recently from 6f3ef6f to ceeabce Compare

December 15, 2024 06:31

steveburnett requested changes

View reviewed changes

Contributor

steveburnett left a comment

Thank you for the documentation! I made some suggestions for ease of reading and clarity.

If you feel that any of my suggestions change the meaning in a way that is not correct, let me know and we can work on them together.

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

pramodsatya force-pushed the add_native_tests branch from ceeabce to 8f606ce Compare

January 14, 2025 19:05

pramodsatya commented

View reviewed changes

Contributor Author

pramodsatya left a comment

Thanks for the feedback @steveburnett, addressed the comments, could you please take another look?

presto-native-tests/README.md Show resolved Hide resolved

presto-native-tests/README.md Show resolved Hide resolved

steveburnett previously approved these changes

View reviewed changes

Contributor

steveburnett left a comment

LGTM!

Thanks for addressing the comments! Looks good.

aditi-pandit reviewed

View reviewed changes

Contributor

aditi-pandit left a comment

@pramodsatya : Lets move the second commit to refactor presto-tests in a separate PR. That would make it easier to review. Lets add this work as a motivation for that refactoring.

presto-native-tests/pom.xml Show resolved Hide resolved

...-tests/src/test/java/com.facebook.presto.nativetests/TestNonIterativeDistributedQueries.java Outdated

+                  protected QueryRunner createQueryRunner() throws Exception
+                  {
+                      return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(
+                              ImmutableMap.of("experimental.iterative-optimizer-enabled", "false"),

Contributor

aditi-pandit Jan 16, 2025

What does this do ? Its important to specify why this test configuration matters.

...-tests/src/test/java/com.facebook.presto.nativetests/TestNonIterativeDistributedQueries.java

+                  }
+                  @Override
+                  protected void createTables()

Contributor

aditi-pandit Jan 16, 2025

Can this function be moved to AbstractTestQueriesNative ?

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                      assertQuery("select reduce_agg(x, array[], (x, y)->array[element_at(x, 2)],  (x, y)->array[element_at(x, 2)]) from (select array[array[1]]) T(x)", "select array[null]");
+                  }
+                  // The following approx_set function tests are overriden since approx_set returns different results in Presto C++.

Contributor

aditi-pandit Jan 16, 2025

Do we have any outward article or documentation for this ? If not, then we should write one.

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  @Test
+                  public void testArrayCumSumDecimals()
+                  {
+                      String functionNotRegisteredError = ".*Scalar function presto.default.array_cum_sum not registered with arguments.*";

Contributor

aditi-pandit Jan 16, 2025

Do we have this error because we don't have this functionality ? I don't see a reason for not building it. Do we have an issue for this ? Please create one if its not there and add the link here.

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  @Override
+                  @Test
+                  public void testDuplicateUnnestRows()

Contributor

aditi-pandit Jan 16, 2025

Do we have an issue for this ?

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  @Override
+                  @Test
+                  public void testSamplingJoinChain()

Contributor

aditi-pandit Jan 16, 2025

key_sampling seems like an important feature. Do we have an issue ?

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  @Override
+                  @Test
+                  public void testScalarSubquery()

Contributor

aditi-pandit Jan 16, 2025

Why is this test separated from the java one ?

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  @Override
+                  @Test
+                  public void testLikePrefixAndSuffixWithChars()

Contributor

aditi-pandit Jan 16, 2025

These failures are because CHAR Is not supported. Lets add the issue here.

But also any reason these are written with CHAR and not VARCHAR ? We could try to split the original test.

...to-native-tests/src/test/java/com.facebook.presto.nativetests/AbstractTestQueriesNative.java Outdated

+                  }
+                  @Override
+                  public void testMergeKHyperLogLog()

Contributor

aditi-pandit Jan 16, 2025

Add an issue for the type not supported and link it here.

prestodb deleted a comment from aditi-pandit

prestodb deleted a comment from aditi-pandit

pramodsatya dismissed steveburnett’s stale review via

a42b0c7

January 22, 2025 07:06

pramodsatya force-pushed the add_native_tests branch from 8f606ce to a42b0c7 Compare

January 22, 2025 07:06

pramodsatya commented

View reviewed changes

Contributor Author

pramodsatya left a comment

Thanks @aditi-pandit, addressed the comments and created missing issues. Also modified this PR to only include test classes with fewer modifications as discussed. Will open follow-up PRs for the remaining larger test classes from #23671, such as AbstractTestQueriesNative.java.
Could you please take another look?

presto-native-tests/pom.xml Show resolved Hide resolved

pramodsatya force-pushed the add_native_tests branch 2 times, most recently from bdd1b9f to 7e62480 Compare

January 23, 2025 03:59

aditi-pandit reviewed

View reviewed changes

Contributor

aditi-pandit left a comment

Thanks @pramodsatya

presto-native-tests/src/test/java/com.facebook.presto.nativetests/TestOrderByQueries.java

+                  private static final String storageFormat = "PARQUET";
+                  @Override
+                  protected QueryRunner createQueryRunner() throws Exception

Contributor

aditi-pandit Jan 23, 2025

Do we plan to overload the expected query runner with the JavaQueryRunner as well ?

Contributor Author

pramodsatya Jan 23, 2025

No we do not plan to overload the expected query runner with javaQueryRunner because it does not account for the datatypes of the computed result when comparing it with the expected values. This limitation is noted here.

...ests/src/test/java/com.facebook.presto.nativetests/TestRepartitionQueriesWithSmallPages.java

+                  @Override
+                  protected QueryRunner createQueryRunner() throws Exception
+                  {
+                      return PrestoNativeQueryRunnerUtils.createNativeQueryRunner(

Contributor

aditi-pandit Jan 23, 2025

Does native engine support these session properties ? Will native side-car catch these ?

Contributor Author

pramodsatya Jan 24, 2025 •

edited

Loading

Thanks for pointing it out, the property experimental.optimized-repartitioning is not applicable to the native engine so removed it. Native engine does support driver.max-page-partitioning-buffer-size, which is required for this test, so retained this config.
The native sidecar currently does not throw an error if a session property is set that is not supported by native engine, this is to support heterogeneous environments. The sidecar is enabled now.

.github/workflows/prestocpp-linux-build-and-unit-test.yml Outdated Show resolved Hide resolved

pramodsatya force-pushed the add_native_tests branch 2 times, most recently from b8c41e4 to 2b7da84 Compare

January 24, 2025 00:47

pramodsatya force-pushed the add_native_tests branch 2 times, most recently from a6b9b90 to f7e6ff8 Compare

January 28, 2025 00:20

pdabre12 mentioned this pull request

Fix failing variadic functions when sidecar is enabled #24579

Merged

6 tasks

aditi-pandit reviewed

View reviewed changes

...ve-tests/src/test/java/com.facebook.presto.nativetests/TestDistributedEngineOnlyQueries.java

+                      assertQuery(chicago, "SELECT DATE '2013-03-22'");
+                      assertQuery(kathmandu, "SELECT DATE '2013-03-22'");
+                      assertQueryFails("SELECT TIME '3:04:05'", timeTypeUnsupportedError);

Contributor

aditi-pandit Feb 27, 2025 •

edited

Loading

@pramodsatya : These are constants and should be evaluated in the co-ordinator. Any more insight into why they failed ? Is it because of side-car ?

Contributor Author

pramodsatya Mar 18, 2025

@aditi-pandit, apologies for the delay. Not sure why this is not evaluated in the coordinator but it is not because of the sidecar. Here is the output of explain:

presto> explain SELECT TIME '3:04:05';
                                                     Query Plan
--------------------------------------------------------------------------------------------------------------------
 - Output[PlanNodeId 5][_col0] => [expr:time]
         Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 9.00, memory: 0.00, network: 0.00}
         _col0 := expr (1:16)
     - Project[PlanNodeId 1][projectLocality = LOCAL] => [expr:time]
             Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 9.00, memory: 0.00, network: 0.00}
             expr := TIME'03:04:05.000'
         - LocalExchange[PlanNodeId 168][ROUND_ROBIN] () => []
                 Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 0.00, memory: 0.00, network: 0.00}
             - Values[PlanNodeId 0] => []
                     Estimates: {source: CostBasedSourceInfo, rows: 1 (9B), cpu: 0.00, memory: 0.00, network: 0.00}
                     ()

aditi-pandit reviewed

View reviewed changes

Contributor

aditi-pandit left a comment

@pramodsatya : This PR is looking very close to complete.

@czentgr : Please can you take a look at the yml and pom files.

presto-tests/src/main/java/com/facebook/presto/tests/QueryAssertions.java Outdated Show resolved Hide resolved

presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueryFramework.java Outdated Show resolved Hide resolved

presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueryFramework.java Outdated Show resolved Hide resolved

...ve-tests/src/test/java/com.facebook.presto.nativetests/TestDistributedEngineOnlyQueries.java Show resolved Hide resolved

...ve-tests/src/test/java/com.facebook.presto.nativetests/TestDistributedEngineOnlyQueries.java Show resolved Hide resolved

pramodsatya force-pushed the add_native_tests branch from f7e6ff8 to 7dded38 Compare

March 16, 2025 19:58

pramodsatya requested a review from czentgr as a code owner

March 16, 2025 19:58

Contributor

steveburnett commented Mar 17, 2025

Please remove the manual PR link in the following format from the release note entries for this PR.


:pr:`12345`

I have updated the Release Notes Guidelines to remove the examples of manually adding the PR link.

== RELEASE NOTES ==
General Changes
* Introduces module presto-native-tests to run end-to-end tests with Presto native workers.

pramodsatya force-pushed the add_native_tests branch from 7dded38 to 531ed76 Compare

March 18, 2025 17:56

czentgr reviewed

View reviewed changes

.github/workflows/prestocpp-linux-build-and-unit-test.yml Outdated Show resolved Hide resolved

pramodsatya force-pushed the add_native_tests branch from 531ed76 to d570eb3 Compare

March 18, 2025 22:10

Contributor

aditi-pandit commented Mar 20, 2025

@amitkdutta @jaystarshot : This PR is the first version of presto-native-tests. This is the suite to run all Java presto-product-tests with the native engine.

Would be great to get your reviews for this PR.

pramodsatya and others added 2 commits

March 20, 2025 15:37


          Refactor testcases for presto-native-tests

35c483b

Co-authored-by: Manoj Negi <manojneg@in.ibm.com>


          [native] Introduce module presto-native-tests

1fa9696

Co-authored-by: Manoj Negi <manojneg@in.ibm.com>

pramodsatya force-pushed the add_native_tests branch from d570eb3 to 1fa9696 Compare

March 20, 2025 22:39

Contributor

aditi-pandit commented Mar 24, 2025

@majetideepak @czentgr : Please can you both take a look at this PR. It would be great to add the presto-native-tests module to the build.

Member

jaystarshot commented Mar 24, 2025 •

edited

Loading

Refactor testcases for presto-native-tests

commit is unrelated here?

Contributor Author

pramodsatya commented Mar 25, 2025

Refactor testcases for presto-native-tests

commit is unrelated here?

@jaystarshot, this commit splits the testcases from presto-tests based on what is supported by the Prestissimo. It is not necessary here but it would help run more Sql queries from these testcases with the native worker.
For instance, testOrderByWithOutputColumnReference in AbstractTestOrderByQueries has three queries involving lambdas that would fail in Prestissimo (since apply function is not supported). Moving these to a separate testcase, testOrderByWithOutputColumnReferenceInLambdas, lets us just disable this testcase and run the remaining ~35 queries from testOrderByWithOutputColumnReference in presto-native-tests.
Is it fine if this commit is retained?

jaystarshot approved these changes

View reviewed changes

aditi-pandit approved these changes

View reviewed changes

Contributor

aditi-pandit left a comment

Thanks @pramodsatya

czentgr approved these changes

View reviewed changes

.github/workflows/prestocpp-linux-build-and-unit-test.yml

                           -Duser.timezone=America/Bahia_Banderas \
                           -T1C
+                prestocpp-linux-presto-native-tests:

Contributor

czentgr Mar 26, 2025

Too much code copying is happening with these test jobs (E22, sidecar plugin and now this one). We will refactor the test jobs after the merge and not make the refactor part of the PR.

pramodsatya merged commit d840d84 into prestodb:master

99 checks passed

pramodsatya deleted the add_native_tests branch

March 26, 2025 14:51

prestodb-ci mentioned this pull request

Add release notes for 0.292 #24825

Merged

30 tasks

unidevel mentioned this pull request

Add release notes for 0.292 unix280/presto#23

Closed

30 tasks

This was referenced May 6, 2025

Add release notes for 0.292 unix280/presto#28

Closed

Add release notes for 0.292 unix280/presto#29

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jaystarshot jaystarshot approved these changes

czentgr czentgr approved these changes

aditi-pandit aditi-pandit approved these changes

steveburnett steveburnett left review comments

feilong-liu Awaiting requested review from feilong-liu feilong-liu is a code owner

elharo Awaiting requested review from elharo elharo is a code owner

vivek-bharathan Awaiting requested review from vivek-bharathan

presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

ScrapCodes Awaiting requested review from ScrapCodes ScrapCodes was automatically assigned from prestodb/ibm-reviewers

Labels