-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[native] Introduce module presto-native-tests #24234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Presto Native Tests | ||
|
|
||
| This module contains end-to-end tests that run queries from test classes in | ||
| the `presto-tests` module with Presto C++ workers. Please build the module | ||
| `presto-native-execution` first. | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| The following command can be used to run all tests in this module: | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| ``` | ||
| mvn test | ||
| -pl 'presto-native-tests' | ||
| -Dtest="com.facebook.presto.nativetests.Test*" | ||
| -Duser.timezone=America/Bahia_Banderas | ||
| -DPRESTO_SERVER=${PRESTO_HOME}/presto-native-execution/cmake-build-debug/presto_cpp/main/presto_server | ||
| -DWORKER_COUNT=${WORKER_COUNT} -T1C | ||
| ``` | ||
| Please update JVM argument `PRESTO_SERVER` to point to the Presto C++ worker | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| binary `presto_server`. | ||
|
|
||
| ## Adding new tests | ||
|
|
||
| Presto C++ currently does not have the same behavior as Presto for certain | ||
| queries. This could be because of missing types, missing function signatures, | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| among other reasons. Tests with these unsupported queries are therefore | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| expected to fail and the test asserts the error message is as expected. | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| Issues should also be created for the failing queries, so they are documented | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| and fixed. Please add the tag `presto-native-tests` for these issues. | ||
steveburnett marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| Once all the failures in a testcase are fixed, the overriden test in this | ||
| module should be removed and the testcase in the corresponding base class in | ||
| `presto-tests` would be the single source of truth for Presto SQL coverage | ||
| tests. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | ||
| <modelVersion>4.0.0</modelVersion> | ||
|
|
||
| <parent> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-root</artifactId> | ||
| <version>0.292-SNAPSHOT</version> | ||
| </parent> | ||
|
|
||
| <artifactId>presto-native-tests</artifactId> | ||
| <name>presto-native-tests</name> | ||
| <description>Presto Native Tests</description> | ||
|
|
||
| <properties> | ||
| <air.main.basedir>${project.parent.basedir}</air.main.basedir> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.testng</groupId> | ||
| <artifactId>testng</artifactId> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-main</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-native-execution</artifactId> | ||
| <version>${project.version}</version> | ||
| <type>test-jar</type> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-tests</artifactId> | ||
| <version>${project.version}</version> | ||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.facebook.presto</groupId> | ||
| <artifactId>presto-tpcds</artifactId> | ||
| <version>${project.version}</version> | ||
aditi-pandit marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <scope>test</scope> | ||
| </dependency> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <!-- Disable git-commit-id-plugin plugin to allow for running tests without | ||
| a git checkout --> | ||
| <plugin> | ||
| <groupId>pl.project13.maven</groupId> | ||
| <artifactId>git-commit-id-plugin</artifactId> | ||
| <configuration> | ||
| <skip>true</skip> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.basepom.maven</groupId> | ||
| <artifactId>duplicate-finder-maven-plugin</artifactId> | ||
| <configuration> | ||
| <ignoredResourcePatterns> | ||
| <ignoredResourcePattern>parquet.thrift</ignoredResourcePattern> | ||
| <ignoredResourcePattern>about.html</ignoredResourcePattern> | ||
| <ignoredResourcePattern>mozilla/public-suffix-list.txt</ignoredResourcePattern> | ||
| <ignoredResourcePattern>iceberg-build.properties</ignoredResourcePattern> | ||
| <ignoredResourcePattern>org.apache.avro.data/Json.avsc</ignoredResourcePattern> | ||
| </ignoredResourcePatterns> | ||
| <ignoredClassPatterns> | ||
| <ignoredClassPattern>com.esotericsoftware.kryo.*</ignoredClassPattern> | ||
| <ignoredClassPattern>com.esotericsoftware.minlog.Log</ignoredClassPattern> | ||
| <ignoredClassPattern>com.esotericsoftware.reflectasm.*</ignoredClassPattern> | ||
| <ignoredClassPattern>module-info</ignoredClassPattern> | ||
| <ignoredClassPattern>META-INF.versions.9.module-info</ignoredClassPattern> | ||
| <ignoredClassPattern>org.apache.avro.*</ignoredClassPattern> | ||
| <ignoredClassPattern>com.github.benmanes.caffeine.*</ignoredClassPattern> | ||
| <ignoredClassPattern>org.roaringbitmap.*</ignoredClassPattern> | ||
| </ignoredClassPatterns> | ||
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <configuration> | ||
| <argLine>-Xms4g -Xmx4g</argLine> | ||
| <forkCount>1</forkCount> | ||
| <reuseForks>false</reuseForks> | ||
| <excludedGroups>remote-function,textfile_reader</excludedGroups> | ||
| <systemPropertyVariables> | ||
| <PRESTO_SERVER>/root/project/build/debug/presto_cpp/main/presto_server</PRESTO_SERVER> | ||
| </systemPropertyVariables> | ||
| </configuration> | ||
| </plugin> | ||
| </plugins> | ||
| </build> | ||
| </project> | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too much code copying is happening with these test jobs (E22, sidecar plugin and now this one). We will refactor the test jobs after the merge and not make the refactor part of the PR.