Skip to content

Conversation

@pdabre12
Copy link
Contributor

@pdabre12 pdabre12 commented Feb 17, 2025

Description

Fixes a bug where variadic functions were failing when sidecar is enabled.

Motivation and Context

presto> select array['1', '2'];
Query 20250214_211118_00013_ab8m9 failed: Unexpected parameters (varchar(1), varchar(1)) for function native.default.array_constructor. Expected: native.default.array_constructor(t) t, native.default.array_constructor() 

presto> select ARRAY [1, 2];
Query 20250214_203804_00004_riwt8 failed: Unexpected parameters (integer, integer) for function native.default.array_constructor. Expected: native.default.array_constructor(t) t, native.default.array_constructor()

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Feb 17, 2025
@pdabre12 pdabre12 marked this pull request as ready for review February 17, 2025 17:33
@pdabre12 pdabre12 requested a review from a team as a code owner February 17, 2025 17:33
@pdabre12 pdabre12 requested a review from presto-oss February 17, 2025 17:33
@pdabre12
Copy link
Contributor Author

@rschlussel @jaystarshot Can you guys please have a look? Thanks.

Copy link
Contributor

@pramodsatya pramodsatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pdabre12, LGTM.

Copy link
Contributor

@rschlussel rschlussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up, can we run all of native tests with both sidecar enabled and disabled?

@pdabre12
Copy link
Contributor Author

@rschlussel Yes, once support for presto-native-tests is added : #24234, we can toggle the sidecar on/off and run the test cases.
Thank you.

@pdabre12 pdabre12 merged commit d6b494a into prestodb:master Feb 18, 2025
58 checks passed
@pdabre12 pdabre12 deleted the fix-varadic-functions branch February 18, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

from:IBM PR from IBM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants