test(native): Add `AbstractTestQueries` to native tests by pramodsatya · Pull Request #23671 · prestodb/presto

pramodsatya · 2024-09-18T01:36:02Z

Description

Adds support to run testcases from AbstractTestQueries with the C++ worker in presto-native-tests. These testcases are run with Presto's iterative optimizer disabled in TestNonIterativeDistributedQueries and with the default native hive query runner in TestTpchDistributedQueries.

Motivation and Context

Improves Presto C++ e2e test coverage with sidecar by extending production tests from presto-tests module to use the native worker.

Release Notes

== RELEASE NOTES ==

General Changes
* Add testcases from `AbstractTestQueries` to `presto-native-tests`.

steveburnett

LGTM! (docs)

Reviewed README.md, no concerns. Thanks for the doc!

tdcmeehan · 2024-09-19T13:17:52Z

Are these tests being run as part of the CI?

pramodsatya · 2024-09-19T15:49:09Z

They are not being run as part of CI currently, but we plan to setup a pipeline to run these tests on a regular cadence subsequently. Will also add a CI job to run these tests in a follow-up PR.

presto-native-tests/src/test/java/com.facebook.presto.nativetests/TestAggregations.java

steveburnett · 2024-11-11T14:57:57Z

Just a suggestions for the release note: Consider using the description of the PR in the release note entry to help a release note reader understand what this module does.

== RELEASE NOTES ==
General Changes
* Add presto-native-tests module to run end-to-end tests with Presto native workers. :pr:`23671`

pramodsatya · 2024-11-11T15:14:33Z

Just a suggestions for the release note: Consider using the description of the PR in the release note entry to help a release note reader understand what this module does.
== RELEASE NOTES ==
General Changes
* Add presto-native-tests module to run end-to-end tests with Presto native workers. :pr:`23671`

Thanks for the suggestion @steveburnett, updated accordingly.

## Description Fixes expected `orderdate` length in `testShowColumns` for `DWRF` file format. ## Motivation and Context Required by tests to be added in #23671 . ``` == NO RELEASE NOTE == ```

pramodsatya · 2025-11-21T01:02:34Z

@aditi-pandit, could you please help review this PR? I addressed the previous review comments and opened issues for failures identified.

...to-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java

Copilot

Pull request overview

This PR adds support for running testcases from AbstractTestQueries with the C++ worker in presto-native-tests. This significantly improves Presto C++ end-to-end test coverage by extending production tests from the presto-tests module to use the native worker.

Key changes:

Added two new test classes (TestTpchDistributedQueries and TestNonIterativeDistributedQueries) that run tests with different optimizer configurations
Created AbstractTestQueriesNative as a base class that extends AbstractTestQueries with C++-specific test overrides and error handling
Updated table creation utilities to support TPC-H standard schema for better test compatibility

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`presto-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java`	New abstract base class that extends AbstractTestQueries with C++-specific test overrides and error message patterns
`presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestTpchDistributedQueries.java`	New test class running testcases with default native hive query runner using PARQUET storage format
`presto-native-tests/src/test/java/com/facebook/presto/nativetests/TestNonIterativeDistributedQueries.java`	New test class running testcases with iterative optimizer disabled using DWRF storage format
`presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java`	Modified queries to add ORDER BY clause and simplified regex patterns for better C++ compatibility
`presto-native-tests/src/test/java/com/facebook/presto/nativetests/NativeTestsUtils.java`	Updated createTables calls to use new parameter for TPC-H standard schema
`presto-native-tests/presto_cpp/tests/custom_functions/CustomFunctions.cpp`	Registered custom_add function for native testing
`presto-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java`	Added useTpchStandardSchema parameter to table creation methods for flexibility in test schema configuration
`presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeIcebergTpchQueries.java`	Updated to use new createLineitemStandard signature with castDateToVarchar parameter
`presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeHiveExternalTableTpchQueries.java`	Updated to use new createLineitemStandard signature with castDateToVarchar parameter
`presto-native-execution/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeCteExecution.java`	Updated to use new createAllTables signature with useTpchStandardSchema parameter
`presto-docs/src/main/sphinx/presto_cpp/limitations.rst`	Added documentation for approx_set function differences between Presto C++ and Presto Java

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...to-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java

...o-native-tests/src/test/java/com/facebook/presto/nativetests/TestTpchDistributedQueries.java

...-tests/src/test/java/com/facebook/presto/nativetests/TestNonIterativeDistributedQueries.java

...-native-execution/src/test/java/com/facebook/presto/nativeworker/NativeQueryRunnerUtils.java

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

aditi-pandit · 2025-12-11T10:39:46Z

...o-native-tests/src/test/java/com/facebook/presto/nativetests/TestTpchDistributedQueries.java

+    @Test
+    public void testAnalyzePropertiesSystemTable()
+    {
+        assertQuery("SELECT COUNT(*) FROM system.metadata.analyze_properties WHERE catalog_name = 'tpch'", "SELECT 0");


@pramodsatya : Why does this fail on native ?

@aditi-pandit, this does not fail on native, it is added here to maintain consistency with the TestTpchDistributedQueries from presto-tests:

presto/presto-tests/src/test/java/com/facebook/presto/tests/TestTpchDistributedQueries.java

Line 43 in 9ebd1f2

public void testAnalyzePropertiesSystemTable()

Ideally the tests here should be moved to a separate abstract class, I can take this up in a subsequent PR?

Yeah... you can move the tests to a separate abstract class. Lets avoid rewriting the tests.

I tried moving these tests out of TestTpchDistributedQueries and into an abstract class, but because we are overriding several tests from the base class AbstractTestQueries for native testing, this refactor does not help avoid rewriting the tests.
Could I add a TODO comment for this?

aditi-pandit

@pramodsatya : Another high level comment: Whether we cast Date depends on the storage format as DWRF doesn't support DATE but Parquet does. Ideally we should use that to guide the casting and avoid the extra parameter as much as possible. Lets cleanup guided by that.

...st/java/com/facebook/presto/nativeworker/AbstractTestNativeHiveExternalTableTpchQueries.java

...ion/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeIcebergTpchQueries.java

aditi-pandit · 2025-12-12T03:51:52Z

presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java

+        assertQuery(session, "select o.custkey, c.name from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
        assertQuery(session, "select o.orderkey, c.name from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
-        assertQuery(session, "select *, cast(o.custkey as varchar), cast(c.custkey as varchar) from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
+        assertQuery(session, "select c.name, cast(o.custkey as varchar), cast(c.custkey as varchar) from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");


Don't follow why these columns are added. Why did * not work ?

The market segment and comment columns in customer table are swapped when select * is used (this happens without the config being tested here as well).

aditi-pandit · 2025-12-12T03:53:59Z

...o-native-tests/src/test/java/com/facebook/presto/nativetests/TestTpchDistributedQueries.java

+    @Test
+    public void testAnalyzePropertiesSystemTable()
+    {
+        assertQuery("SELECT COUNT(*) FROM system.metadata.analyze_properties WHERE catalog_name = 'tpch'", "SELECT 0");


Yeah... you can move the tests to a separate abstract class. Lets avoid rewriting the tests.

...to-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java

aditi-pandit · 2025-12-12T03:57:48Z

...to-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java

+        assertQueryFails("SELECT greatest(rgb(255, 0, 0))", errorMessage);
+    }
+
+    /// The output JSON formatted string is different in Presto C++.


@amitkdutta : Can you review these tests for json_format usage ?

pramodsatya

Thanks @aditi-pandit, I have reverted the castDateToVarchar parameter to use storageFormat instead, and separated this change to #26955.

Could you please take another look?

...st/java/com/facebook/presto/nativeworker/AbstractTestNativeHiveExternalTableTpchQueries.java

...ion/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeIcebergTpchQueries.java

pramodsatya · 2026-01-08T16:21:13Z

...o-native-tests/src/test/java/com/facebook/presto/nativetests/TestTpchDistributedQueries.java

+    @Test
+    public void testAnalyzePropertiesSystemTable()
+    {
+        assertQuery("SELECT COUNT(*) FROM system.metadata.analyze_properties WHERE catalog_name = 'tpch'", "SELECT 0");


I tried moving these tests out of TestTpchDistributedQueries and into an abstract class, but because we are overriding several tests from the base class AbstractTestQueries for native testing, this refactor does not help avoid rewriting the tests.
Could I add a TODO comment for this?

pramodsatya · 2026-01-08T16:33:56Z

presto-tests/src/main/java/com/facebook/presto/tests/AbstractTestQueries.java

+        assertQuery(session, "select o.custkey, c.name from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
        assertQuery(session, "select o.orderkey, c.name from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
-        assertQuery(session, "select *, cast(o.custkey as varchar), cast(c.custkey as varchar) from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");
+        assertQuery(session, "select c.name, cast(o.custkey as varchar), cast(c.custkey as varchar) from orders o join customer c on cast(o.custkey as varchar) = cast(c.custkey as varchar)");


The market segment and comment columns in customer table are swapped when select * is used (this happens without the config being tested here as well).

…on storageFormat (#26955) ## Description Reverts parameter `castDateToVarchar` in helper methods used to create Tpch tables for testing. Passes in the `storageFormat` instead, and modifies the `createTable` methods to use the storage format to decide if `Date` columns should be cast to `Varchar`. ## Motivation and Context Cleanup test utility methods for `presto-native-tests`: #23671. ## Impact NA. ## Test Plan Verified with existing native e2e tests. ``` == NO RELEASE NOTE == ```

steveburnett · 2026-01-29T15:41:50Z

Consider rebasing the PR to rerun the tests.

pramodsatya · 2026-02-16T21:14:13Z

@aditi-pandit, @czentgr, could you please help review these tests?

pramodsatya requested review from aditi-pandit, majetideepak and mknegi September 18, 2024 01:36

steveburnett previously approved these changes Sep 18, 2024

View reviewed changes

pramodsatya dismissed steveburnett’s stale review via acaa071 September 19, 2024 04:04

pramodsatya force-pushed the presto-native-tests branch 2 times, most recently from acaa071 to 8ec8208 Compare September 19, 2024 04:56

pramodsatya marked this pull request as ready for review September 19, 2024 04:57

pramodsatya requested review from a team, elharo, feilong-liu, jaystarshot and vivek-bharathan as code owners September 19, 2024 04:57

pramodsatya requested a review from presto-oss September 19, 2024 04:57

mknegi previously approved these changes Sep 19, 2024

View reviewed changes

jaystarshot reviewed Sep 19, 2024

View reviewed changes

presto-native-tests/src/test/java/com.facebook.presto.nativetests/TestAggregations.java Outdated Show resolved Hide resolved

pramodsatya dismissed mknegi’s stale review via 32b2ad6 October 1, 2024 03:48

pramodsatya force-pushed the presto-native-tests branch 2 times, most recently from 32b2ad6 to f614cb6 Compare October 7, 2024 21:16

pdabre12 mentioned this pull request Nov 1, 2024

Add a native function namespace manager #23358

Merged

6 tasks

pramodsatya force-pushed the presto-native-tests branch 3 times, most recently from 11d653c to 47ecc65 Compare November 11, 2024 07:49

tdcmeehan self-assigned this Nov 11, 2024

zuyu mentioned this pull request Nov 15, 2024

ClassCastException in testArrayCumSum: Double cannot be cast to Float #23754

Closed

pramodsatya force-pushed the presto-native-tests branch from 94746ea to e8b547d Compare November 21, 2025 01:00

github-code-quality bot found potential problems Nov 21, 2025

View reviewed changes

...to-native-tests/src/test/java/com/facebook/presto/nativetests/AbstractTestQueriesNative.java Fixed Show fixed Hide fixed

Copilot AI review requested due to automatic review settings December 4, 2025 01:06

pramodsatya force-pushed the presto-native-tests branch from e8b547d to 020e735 Compare December 4, 2025 01:06

Copilot started reviewing on behalf of pramodsatya December 4, 2025 01:07 View session

Copilot finished reviewing on behalf of pramodsatya December 4, 2025 01:09

Copilot AI reviewed Dec 4, 2025

View reviewed changes

pramodsatya force-pushed the presto-native-tests branch from 020e735 to 4770a1b Compare December 4, 2025 01:30

pramodsatya requested a review from Copilot December 4, 2025 01:30

Copilot started reviewing on behalf of pramodsatya December 4, 2025 01:31 View session

Copilot finished reviewing on behalf of pramodsatya December 4, 2025 01:34

Copilot AI reviewed Dec 4, 2025

View reviewed changes

aditi-pandit reviewed Dec 11, 2025

View reviewed changes

aditi-pandit reviewed Dec 12, 2025

View reviewed changes

...st/java/com/facebook/presto/nativeworker/AbstractTestNativeHiveExternalTableTpchQueries.java Outdated Show resolved Hide resolved

...ion/src/test/java/com/facebook/presto/nativeworker/AbstractTestNativeIcebergTpchQueries.java Outdated Show resolved Hide resolved

aditi-pandit reviewed Dec 12, 2025

View reviewed changes

pramodsatya force-pushed the presto-native-tests branch 2 times, most recently from a949c4a to 8ab36e6 Compare January 13, 2026 17:05

pramodsatya commented Jan 13, 2026

View reviewed changes

pramodsatya mentioned this pull request Jan 13, 2026

chore(native): Revert castDateToVarchar parameter and add cast based on storageFormat #26955

Merged

pramodsatya force-pushed the presto-native-tests branch from 8ab36e6 to 4115820 Compare January 13, 2026 20:05

pramodsatya force-pushed the presto-native-tests branch from 4115820 to d3c892a Compare January 14, 2026 02:08

This was referenced Jan 23, 2026

fix(native): Add support for kHyperLogLog type in NativeTypeManager #26978

Merged

refactor(testing): Move testMapBlockBug to TestExpressionInterpreter #27019

Closed

pramodsatya added 2 commits February 16, 2026 12:56

refactor(testing): Refactor testcases for native-tests

b8e1fdf

test(native): Add AbstractTestQueries to native-tests

01c0934

Conversation

pramodsatya commented Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Release Notes

Uh oh!

steveburnett left a comment

Choose a reason for hiding this comment

Uh oh!

tdcmeehan commented Sep 19, 2024

Uh oh!

pramodsatya commented Sep 19, 2024

Uh oh!

Uh oh!

steveburnett commented Nov 11, 2024

Uh oh!

pramodsatya commented Nov 11, 2024

Uh oh!

pramodsatya commented Nov 21, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pramodsatya Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aditi-pandit left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pramodsatya left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

steveburnett commented Jan 29, 2026

Uh oh!

pramodsatya commented Feb 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

pramodsatya commented Sep 18, 2024 •

edited

Loading

pramodsatya Dec 11, 2025 •

edited

Loading