[docs] Add presto_cpp/properties-session.rst#23852
Merged
steveburnett merged 1 commit intoprestodb:masterfrom Oct 18, 2024
Merged
[docs] Add presto_cpp/properties-session.rst#23852steveburnett merged 1 commit intoprestodb:masterfrom
steveburnett merged 1 commit intoprestodb:masterfrom
Conversation
This was referenced Oct 17, 2024
44a124a to
034f049
Compare
Contributor
Author
|
New update to fix |
tdcmeehan
approved these changes
Oct 18, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new page presto_cpp/properties-session.rst, separating out the content in the Session Properties heading in Presto C++ Features to a separate page.
Note: This is a redo of #23789 to resolve the conflict created from the recently merged #23846 and include the session property added in that PR. Local doc builds were used to verify the correct placement of the new
native_expression.max_array_size_in_reducesession property in this updated PR.Motivation and Context
The Presto Properties Reference documentation contains mostly configuration properties, with session properties being mentioned occasionally within the description of the configuration properties, and both categories are incompletely documented.
To elevate the visibility of session properties and hopefully make it easier to eventually address the incompleteness of both categories, session property doc is being moved to its own page that is separate from and parallel to the configuration properties documentation.
Both the Presto and Presto C++ properties documentation need similar refactoring.
This PR addresses only the Presto C++ session properties doc refactoring, to make the PR itself shorter and simpler to review. The work to refactor the larger Presto Properties Reference doc will follow in a separate PR.
Impact
Documentation.
Test Plan
Ran local docs builds to verify that content was where it should be, and that the new and modified pages are correctly formatted.
Contributor checklist
Release Notes